In README, better highlight how to add Webpacker to an existing app #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just saw #372, @gauravtiwari your changes the the README might encompass this, feel free to close or copy/paste my stuff into your PR. Thanks for updating the docs. |
|
thanks @aguynamedben. Yes, makes sense to do it there 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved the docs because I'm an experienced Rails user and when I went to explore the new webpacker/yarn stuff with Rails 5.1, I wondered for 20 minutes why
rake -Twas showingyarn:installas expected but not thewebpacker:*commands. The instructions for "how do I start using this new feature with my existing" we're pretty buried in the README.