-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update documentation with how to change config in the top level readm… #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation with how to change config in the top level readm… #846
Conversation
…e. Also reveal how to make use of internal functions
Thanks for this. Please could you move all webpack related doc to |
…agraph and link to webpack.md
@gauravtiwari No problem. I left in the intro paragraph and link over to |
docs/webpack.md
Outdated
@@ -36,6 +36,14 @@ const customConfig = require('./custom') | |||
module.exports = merge(environment.toWebpackConfig(), customConfig) | |||
``` | |||
|
|||
If you need access to functions within Webpacker's configuration, you can import them like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we call it configs instead of functions?
README.md
Outdated
environment in their respective files or configure them all in the base | ||
`config/webpack/environment.js` file. | ||
|
||
By default, you shouldn't have to make any changes to `config/webpack/*.js` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you shouldn't have
=> you don't need to
Thanks Greg 👍 Looks good, just some minor change to wording |
Tweaked both Readme and Webpack so they are consistent. Thanks for the speedy feedback 👍 |
Thank you. Totally missed the duplicate content between webpack and README so I have taken liberty to remove that. If you could please update TOC with doctoc, I will merge 👍 |
Done, Thank you 👍 |
thanks 🍰 🍬 |
…e. Also reveal how to make use of internal functions
Takes comment from here: #794 (comment) on how to export internal functions for use.
Fixes #802