Skip to content

Fix history pagination with paper_trail, specs #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2014
Merged

Fix history pagination with paper_trail, specs #2054

merged 1 commit into from
Aug 27, 2014

Conversation

vlobanov
Copy link

Hi!
When using PaperTrail extension, RailsAdmin::Extensions::PaperTrail::AuditingAdapter was returning VersionProxy objects array:

versions.collect { |version| VersionProxy.new(version, @user_class) }

which is later used in history view:

- unless params[:all] || [email protected]_to?(:current_page)

The array returned by collect obviously doesn't respond to #current_page, as a result history pages have no pagination. Fix, and PaperTrail integration specs

@kirillplatonov
Copy link

👍

mshibuya added a commit that referenced this pull request Aug 27, 2014
Fix history pagination with paper_trail, specs
@mshibuya mshibuya merged commit 3aa28f4 into railsadminteam:master Aug 27, 2014
@mshibuya
Copy link
Member

Looks nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants