Adds .fromGit and buildLocal

[MichealReed]

This adds a new factory fromGit and a flag that can be passed to both factories buildLocal. Had to manually init the directory instead of clone it so that we have control over the name of the directory the sources are pulled to.

Not sure how you want to split the example, added line comments to the add project's build hook for now.

I looked at adding a test but there are currently many failures with the defaults, these are mostly imported from the _c library?

closes #5

[rainyl]

@MichealReed Thanks! I have reviewed it.

Not sure how you want to split the example, added line comments to the add project's build hook for now.

Okay, adding a new example like libadd_from_git inside example dir is fine.

I looked at adding a test but there are currently many failures with the defaults, these are mostly imported from the _c library?

You can add a test and I can offer some help to figure it out 😄

[MichealReed]

@MichealReed Thanks! I have reviewed it.

Not sure how you want to split the example, added line comments to the add project's build hook for now.

Okay, adding a new example like libadd_from_git inside example dir is fine.

I looked at adding a test but there are currently many failures with the defaults, these are mostly imported from the _c library?

You can add a test and I can offer some help to figure it out 😄

If both the dart_cli and flutter examples are wired to use add, I do not see how the example could be used by adding add_from_git. Maybe it's better to demonstrate these from the same hook with a bool?

[rainyl]

If both the dart_cli and flutter examples are wired to use add, I do not see how the example could be used by adding add_from_git. Maybe it's better to demonstrate these from the same hook with a bool?

just create a new example named libadd_from_git or something else is okay for now, it's just an example showing how to use the package, with dart-lang/native#39 landed, it will be easier to switch between different constructors.

[MichealReed]

If both the dart_cli and flutter examples are wired to use add, I do not see how the example could be used by adding add_from_git. Maybe it's better to demonstrate these from the same hook with a bool?

just create a new example named libadd_from_git or something else is okay for now, it's just an example showing how to use the package, with dart-lang/native#39 landed, it will be easier to switch between different constructors.

I added a runBuildGit to the hook helpers and

    const exampleGit = false;
    if (!exampleGit) {
      await runBuild(input, output, sourceDir);
    } else {
      await runBuildGit(input, output, sourceDir);
    }

Can we use this approach instead?

[rainyl]

I added a runBuildGit to the hook helpers and

    const exampleGit = false;
    if (!exampleGit) {
      await runBuild(input, output, sourceDir);
    } else {
      await runBuildGit(input, output, sourceDir);
    }

Can we use this approach instead?

Sure, it's clearer, great jobs.

[MichealReed]

Sure, it's clearer, great jobs.

Thanks! Tests added to builder/cmake_builder_git_test.dart too. Good to merge?

[rainyl]

Thanks! Tests added to builder/cmake_builder_git_test.dart too. Good to merge?

I am facing a problem when testing.

As you can see, some users like me are still using master as default branch name, and if gitBranch is different, it will be failed.

So maybe we should fetch first and checkout to gitBranch or gitCommit?

Also, Process.runSync used in the constructor only logs stdout, but errors are not correctly processed, so I added runProcessSync() to do this, could you please finish the rest since it's late here, thanks~

Please let me know if you do not like runProcessSync or my other changes.

[MichealReed]

Thanks! Tests added to builder/cmake_builder_git_test.dart too. Good to merge?

I am facing a problem when testing.

As you can see, some users like me are still using master as default branch name, and if gitBranch is different, it will be failed.

So maybe we should fetch first and checkout to gitBranch or gitCommit?

Also, Process.runSync used in the constructor only logs stdout, but errors are not correctly processed, so I added runProcessSync() to do this, could you please finish the rest since it's late here, thanks~

Please let me know if you do not like runProcessSync or my other changes.

Ah I think this is why we need to use fetch. Will mess around with this in a few hours.

[MichealReed]

Ok, this should work we use --

mkdir test
git init
git remote add origin gitURL
git fetch origin gitBranch
git reset --hard gitCommit or FETCH_HEAD (default)

[rainyl]

Ok, this should work we use --

mkdir test git init git remote add origin gitURL git fetch origin gitBranch git reset --hard gitCommit or FETCH_HEAD (default)

Great jobs! I have made some small changes and improved testing, now LGTM.

I will merge it if it's also looks good to you.

[MichealReed]

Looks good to me, thanks for the improvements!

[rainyl]

@MichealReed Thanks for your contributions! 😄