Pin quickstart/vagrant Rancher version #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
changed the title
|
I noticed the agent docker command has Happy to include that change if necessary but I imagine all that work should be done at a later date in a consistent manner. (At the same time as upgrading the other platforms to 2.5) |
Dean-Coakley
commented
Oct 16, 2020
|
@nikkelma Can you take a look at this? Any more changes required? Thanks. |
nikkelma
approved these changes
Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced: #129
But after applying that workaround it looked like there was other changes potentially required for 2.5 and I noticed that e7f8e6c pinned the versions for the other providers.
I think pinning the version of Rancher is good idea for future stability to prevent silent regressions after new Rancher releases.