Skip to content

Incorrect tables in SPI Hardware documentation #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
e107steved opened this issue Aug 20, 2021 · 4 comments · Fixed by #2107
Closed

Incorrect tables in SPI Hardware documentation #2104

e107steved opened this issue Aug 20, 2021 · 4 comments · Fixed by #2107
Labels
bug linked pull request Has a linked Pull Request that will close the issue.

Comments

@e107steved
Copy link

At https://www.raspberrypi.org/documentation/computers/raspberry-pi.html#spi-hardware there are two tables related to SPI mappings only available on the compute modules (SPI0, SPI2), which are currently incomprehensible.
It looks as if the tables need to be converted to three columns; then maintain the current text order to repopulate the cells.

@ghost
Copy link

ghost commented Aug 20, 2021

Well spotted. That's partly my fault. These tables were all completely broken when the documentation moved to the new toolchain (see #1911). When I noticed they were broken I attempted to fix them, but failed to notice that some were meant to be 3 columns, some 4. I will do some further tweaking.

@lurch lurch added the bug label Aug 20, 2021
@e107steved
Copy link
Author

Incidentally, I couldn't see any reference to the SPI0 and SPI2 alternate mappings in the CM4 data sheet (specifically the 'Alternative Function Assignments' table section 2.5.1). So either the generic documentation needs a note to say the additional mappings aren't available on the CM4, or the CM4 data sheet needs an update to both the alternate function table and the pinout listing.

@ghost
Copy link

ghost commented Aug 20, 2021

I've filed a PR, #2107, which fixes this.

@ghost
Copy link

ghost commented Aug 20, 2021

Incidentally, I couldn't see any reference to the SPI0 and SPI2 alternate mappings in the CM4 data sheet (specifically the 'Alternative Function Assignments' table section 2.5.1). So either the generic documentation needs a note to say the additional mappings aren't available on the CM4, or the CM4 data sheet needs an update to both the alternate function table and the pinout listing.

You should file a separate issue for that - best to keep each GitHub issue to a single issue, if you see what I mean.

@lurch lurch linked a pull request Aug 20, 2021 that will close this issue
@lurch lurch added the linked pull request Has a linked Pull Request that will close the issue. label Aug 20, 2021
aallan pushed a commit that referenced this issue Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug linked pull request Has a linked Pull Request that will close the issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants