Skip to content

Update net_tutorial.md to allow DNS server to be used for internal systems. #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

Treah
Copy link
Contributor

@Treah Treah commented Jan 6, 2021

Specifying Port=0 is not required and will actually cause problems if you are using this for other systems on the network needing DNS services. It should be omitted allowing the default port to be used. I assume this is probably originally put in here to prevent users from making a DNS server that is a security risk but there should at least be a comment about it as I have added here.

Specifying Port=0 is not required and will actually cause problems if you are using this for other systems on the network needing DNS services. It should be omitted allowing the default port to be used. I assume this is probably originally put in here to prevent users from making a DNS server that is a security risk but there should at least be a comment about it as I have added here.
@aallan
Copy link
Contributor

aallan commented Jun 7, 2021

I'd encourage you to wrap this PR up in the next week or so as we're in the process of transitioning the documentation from the current Markdown-based source format to Asciidoc. At some point soon — probably around the end of June, beginning of July — we will freeze the current documentation repo. After that time contributions and PRs based on the Markdown source will not be accepted, and any PRs that are still open will be closed.

See #1911 for full details.

@aallan aallan added the ready to merge The OP says this PR is ready to merge? Anyone object? label Jun 8, 2021
@Treah
Copy link
Contributor Author

Treah commented Jun 14, 2021

I'd encourage you to wrap this PR up in the next week or so as we're in the process of transitioning the documentation from the current Markdown-based source format to Asciidoc. At some point soon — probably around the end of June, beginning of July — we will freeze the current documentation repo. After that time contributions and PRs based on the Markdown source will not be accepted, and any PRs that are still open will be closed.

See #1911 for full details.

How would I go about merging this? I do not have write access to the repo. This is just a simple change in the documentation.

@JamesH65 JamesH65 merged commit 66cd556 into raspberrypi:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The OP says this PR is ready to merge? Anyone object?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants