Skip to content

Update php5 and php7.0 references to php7.3 #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

adrianyorke
Copy link
Contributor

Fixes: #1811

@adrianyorke adrianyorke changed the title Update php5 references to php7.3 Update php5 and php7.0 references to php7.3 Feb 3, 2021
@adrianyorke
Copy link
Contributor Author

adrianyorke commented Feb 3, 2021

Please note: the "unix:/var/run/..." syntax seems to have changed to "unix:/run/" in the php7.3 default config file. The changes in this PR use the revised syntax.

@aallan
Copy link
Contributor

aallan commented Jun 7, 2021

I'd encourage you to wrap this PR up in the next week or so as we're in the process of transitioning the documentation from the current Markdown-based source format to Asciidoc. At some point soon — probably around the end of June, beginning of July — we will freeze the current documentation repo. After that time contributions and PRs based on the Markdown source will not be accepted, and any PRs that are still open will be closed.

See #1911 for full details.

@adrianyorke
Copy link
Contributor Author

@aallan This branch has no conflicts and is a relatively minor update. I have no further commits for this PR unless there are review observations - I don't see any? I recommend this is merged prior to asciidoc migration the transition process starts with an accurate base. Thanks for the reminder and best wishes with the transition.

@aallan aallan added the ready to merge The OP says this PR is ready to merge? Anyone object? label Jun 7, 2021
@JamesH65 JamesH65 merged commit bf50966 into raspberrypi:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The OP says this PR is ready to merge? Anyone object?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NGINX web server setup document contains inconsistent references to both php5 and php7.0, should be php7.3
3 participants