-
Notifications
You must be signed in to change notification settings - Fork 2k
Update access-point-bridged.md #1929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
br_filter blocks traffic on the bridge for DHCP these changes remove the block
Not technically competent enough to know what this means, but it's conditional, so LGTM. |
I was pretty much thinking the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't confirm the proc/
changes either but I spotted a couple of issues that should probably be fixed.
``` | ||
if they return 1 or true as above you can temporarily disable for testing by these commands: | ||
``` | ||
sudo echo 0 | tee /proc/sys/net/bridge/bridge-nf-call-arptables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will run echo
as root and then redirect the output to the file as a normal user, so it will likely fail with an access denied error. It should be echo 0 | sudo tee ...
instead.
sudo echo 0 | tee /proc/sys/net/bridge/bridge-nf-call-ip6tables | ||
0 | ||
``` | ||
or edit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editing this file will make the change permanent, but you've said above that these commands are only temporary. I think you should probably make it clear that changing sysctl.conf
should only be done once the reader is happy to make the change persist across a reboot.
I'm probably going to be freezing the current markdown-based documentation tree, and deleting any pending PRs, at the end of the week (see #1911 for more information as to why). So if we're going to merge this, probably need to finalise it before Wednesday or Thursday. |
I'm going to be freezing the current Markdown-based repo for PRs on Monday morning, see #1911 for details of what's going on. If this PR isn't merged before then it will unfortunately be deleted. Although we'll be happy to get a new PR against the new Asciidoc-based repo after that goes public — which will probably at the start of August. |
Closed due to #1911. Happy to have a new PR against the new Asciidoc-based repo after that goes public — which will probably at the start of August. |
br_filter blocks traffic on the bridge for DHCP
these changes remove the block