Skip to content

explain how [pi400]/[cm4] conditional filters interact with [pi4] #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

clockfort
Copy link
Contributor

@clockfort clockfort commented Jul 9, 2021

see raspberrypi/firmware#1496 (comment) for citation/background; the current behaviour is poorly documented.

Sorry for making the table a little ugly though. I would have made this note a footnote instead, but I don't know what flavours of extended markdown will work with your guys' html documentation generator, etc.

Thanks!

@JamesH65
Copy link
Contributor

JamesH65 commented Jul 9, 2021

This might be better as a footnote rather than inline. Also the reference should be for Pi 400 and CM4 - note capitalisation.

@clockfort
Copy link
Contributor Author

reworded and made the requested changes

@aallan
Copy link
Contributor

aallan commented Jul 9, 2021

I'm going to be freezing the current Markdown-based repo for PRs on Monday morning, see #1911 for details of what's going on. If this PR isn't merged before then it will unfortunately be deleted. Although we'll be happy to get a new PR against the new Asciidoc-based repo after that goes public — which will probably at the start of August.

@clockfort
Copy link
Contributor Author

I'm going to be freezing the current Markdown-based repo for PRs on Monday morning, see #1911 for details of what's going on. If this PR isn't merged before then it will unfortunately be deleted. Although we'll be happy to get a new PR against the new Asciidoc-based repo after that goes public — which will probably at the start of August.

Ah, no worries, thanks for the explanation. Good luck with your migration, I'll see you in a month I guess if no one merges this over the weekend.

@JamesH65 JamesH65 merged commit e4cef2e into raspberrypi:master Jul 9, 2021
@JamesH65
Copy link
Contributor

JamesH65 commented Jul 9, 2021

LGTM so merged before the deadline!

@clockfort clockfort deleted the patch-1 branch July 9, 2021 22:37
@lurch
Copy link
Contributor

lurch commented Jul 10, 2021

Doesn't really matter now, but perhaps this should have been added to the "It is important to note that the Raspberry Pi Zero W will see the contents of [pi0w] AND [pi0]. Likewise, a Raspberry Pi 3B Plus sees [pi3+] AND [pi3]. If you want a setting to apply only to Pi Zero or Pi 3B you need to follow it (order is important) with a setting in the [pi0w] or [pi3+] section that reverts it." paragraph?

@clockfort
Copy link
Contributor Author

Doesn't really matter now, but perhaps this should have been added to the "It is important to note that the Raspberry Pi Zero W will see the contents of [pi0w] AND [pi0]. Likewise, a Raspberry Pi 3B Plus sees [pi3+] AND [pi3]. If you want a setting to apply only to Pi Zero or Pi 3B you need to follow it (order is important) with a setting in the [pi0w] or [pi3+] section that reverts it." paragraph?

I agree. I just didn't see that paragraph as it didn't match the newer keywords I was searching for.

lurch added a commit that referenced this pull request Jul 10, 2021
@lurch
Copy link
Contributor

lurch commented Jul 10, 2021

@clockfort What do you think to #1943 ?

aallan pushed a commit that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants