Skip to content

defconfig differences #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ali1234 opened this issue Apr 1, 2017 · 3 comments
Closed

defconfig differences #1941

ali1234 opened this issue Apr 1, 2017 · 3 comments

Comments

@ali1234
Copy link
Contributor

ali1234 commented Apr 1, 2017

I ran a diff of bcmrpi_defconfig and bcm2709_defconfig in 4.11.y and I found some differences that don't seem to make sense. This is the full diff:

-ARCH_MULTI_V6 y
-ARCH_MULTI_V7 n
-CRYPTO_AES_ARM m
-CRYPTO_CRYPTD m
-CRYPTO_SHA1_ARM m
-CRYPTO_SHA512 m
-USB_AUDIO m
-USB_CDC_COMPOSITE m
-USB_ETH m
-USB_GADGETFS m
-USB_G_ACM_MS m
-USB_G_HID m
-USB_G_MULTI m
-USB_G_PRINTER m
-USB_G_SERIAL m
-USB_G_WEBCAM m
-USB_MASS_STORAGE m
-USB_MIDI_GADGET m
-USB_ZERO m
+CPU_FREQ_GOV_SCHEDUTIL y
+CRYPTO_AES_ARM_BS m
+CRYPTO_SHA1_ARM_NEON m
+GPIO_BCM_EXP y
+GPIO_BCM_VIRT y
+KERNEL_MODE_NEON y
+LOCALVERSION "-v7"
+NEON y
+RCU_TRACE n
+SMP y
+TOUCHSCREEN_EKTF2127 m
+VMSPLIT_2G y

Some of these are obvious: the different CPU architecture, the USB gadget stuff, NEON stuff, optimized crypto routines. But then there's the stuff I don't understand:

Why does only bcmrpi have CRYPTO_CRYPTD and CRYPTO_SHA512?

Why does only bcm2709 have CPU_FREQ_GOV_SCHEDUTIL and RCU_TRACE? Are these only for SMP systems?

Why does only bcm2709 have TOUCHSCREEN_EKTF2127?

@pelwell
Copy link
Contributor

pelwell commented May 15, 2017

I just independenty noticed the TOUCHSCREEN_EKTF2127 discrepancy. The option must have been added to bcm2709_defconfig somewhere between 4.8 and 4.9, but the commit has been squashed (unless it was a merge error). Do you remember this, @popcornmix?

Apart from that:

  1. RCU_TRACE=n is the default on BCM2708, so it won't appear in the defconfig since it only includes non-default options, but something else in BCM2709 configurations is causing it to be enabled - hence the need for it to be explicitly disabled.

  2. I'm going to guess that the NEON crypto configs make the other CRYPTO_ configs redundant or unwanted - ah yes, CRYPTO_AES_ARM_BS selects CRYPTO_SIMD which selects CRYPTO_CRYPTD.

  3. And the SCHEDUTIL governor option depends on SMP.

@popcornmix
Copy link
Collaborator

I couldn't find a reference to TOUCHSCREEN_EKTF2127 ever being requested. As such I've now removed it (but would be willing to add it to both if anyone actually uses it).

popcornmix added a commit to raspberrypi/firmware that referenced this issue May 21, 2017
kernel: usb/serial/ch341: Add parity support
See: raspberrypi/linux#1863

kernel: config: Add FB_TFT_ST7789V module
See: raspberrypi/linux#1474

kernel: config: Add CONFIG_I2C_ROBOTFUZZ_OSIF
See: raspberrypi/linux#2017

kernel: config: Add CONFIG_TOUCHSCREEN_EDT_FT5X06
See: raspberrypi/linux#2014

kernel: config: Drop CONFIG_TOUCHSCREEN_EKTF2127
See: raspberrypi/linux#1941

kernel: config: Add Goodix touch controller module
See: raspberrypi/linux#1609

kernel: serial: 8250: Add CAP_MINI, set for bcm2835aux
See: raspberrypi/linux#1561
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this issue May 21, 2017
kernel: usb/serial/ch341: Add parity support
See: raspberrypi/linux#1863

kernel: config: Add FB_TFT_ST7789V module
See: raspberrypi/linux#1474

kernel: config: Add CONFIG_I2C_ROBOTFUZZ_OSIF
See: raspberrypi/linux#2017

kernel: config: Add CONFIG_TOUCHSCREEN_EDT_FT5X06
See: raspberrypi/linux#2014

kernel: config: Drop CONFIG_TOUCHSCREEN_EKTF2127
See: raspberrypi/linux#1941

kernel: config: Add Goodix touch controller module
See: raspberrypi/linux#1609

kernel: serial: 8250: Add CAP_MINI, set for bcm2835aux
See: raspberrypi/linux#1561
@JamesH65
Copy link
Contributor

I think this can be closed as answered. All happy with that? Reopen if not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants