Skip to content

Rpi3B+ kernel oops phy_ethtool_ksettings_get #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
penfold42 opened this issue Mar 17, 2018 · 9 comments
Closed

Rpi3B+ kernel oops phy_ethtool_ksettings_get #2442

penfold42 opened this issue Mar 17, 2018 · 9 comments

Comments

@penfold42
Copy link

penfold42 commented Mar 17, 2018 •
edited
Loading

SNMPd was starting early in the boot process and triggered an oops just like:

https://patchwork.kernel.org/patch/10282365/

Apologies if this patch is already on the list but I couldn’t find any recent commits that include it
@pelwell pelwell mentioned this issue Mar 20, 2018
Closed
@macmpi macmpi mentioned this issue Mar 21, 2018
Closed
@HiassofT HiassofT mentioned this issue Mar 26, 2018
Closed
@graysky2
Copy link

graysky2 commented Mar 27, 2018 •
edited
Loading

@pelwell - In reference to #2437 ... I applied the patch building 4.14.27, upon booting into it, my network was unable to come up. I see nothing in dmesg or journalctl with errors. The status of the service:

● systemd-networkd.service - Network Service
   Loaded: loaded (/usr/lib/systemd/system/systemd-networkd.service; enabled; vendor preset: enabled)
   Active: active (running) since Fri 2018-03-23 15:02:48 EDT; 20s ago
     Docs: man:systemd-networkd.service(8)
 Main PID: 441 (systemd-network)
   Status: "Processing requests..."
    Tasks: 1 (limit: 1831)
   CGroup: /system.slice/systemd-networkd.service
           └─441 /usr/lib/systemd/systemd-networkd

Mar 23 15:02:48 pi3 systemd[1]: Starting Network Service...
Mar 23 15:02:48 pi3 systemd-networkd[441]: Enumeration completed
Mar 23 15:02:48 pi3 systemd[1]: Started Network Service.
Mar 23 15:02:48 pi3 systemd-networkd[441]: lo: Link is not managed by us

I am building 4.14.30 now with the patched source to test as well.

@pelwell
Copy link
Contributor

pelwell commented Mar 27, 2018

There may be an interaction with the other patches we've applied.

@graysky2
Copy link

There may be an interaction with the other patches we've applied.

Confirmed with 4.14.30 as well. At least it allows for a boot without kernel oops with a bridge network... you just can't bring the network up :D

@penfold42
Copy link
Author

Sounds like what I saw with OSMC:
osmc/osmc@21eb49b

https://discourse.osmc.tv/t/rpi3b-kernel-oops-phy-ethtool-ksettings-get/71548

@graysky2
Copy link

graysky2 commented Mar 28, 2018 •
edited
Loading

@pelwell - Do you think either of the recent commits will help this issue?

9696aab
6612300

(Building now to test).

@pelwell
Copy link
Contributor

pelwell commented Mar 28, 2018

No, I don't. The later commit message says:

 This simpler
patch should be considered a stepping stone that may prevent some of the
crashes seen when the interface is reset but without solving the early
access problem.

and this issue falls into the category of early access.

pelwell pushed a commit that referenced this issue Apr 4, 2018
lan78xx: Don't reset the interface on open
b5b6bb9 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
popcornmix added a commit to raspberrypi/firmware that referenced this issue Apr 4, 2018
@popcornmix
kernel: net: lan78xx: Allow for VLAN headers in timeout
0dff9ec 
See: raspberrypi/linux#2458

kernel: Revert lan78xx: Simple patch to prevent some crashes
kernel: lan78xx: Connect phy early
kernel: lan78xx: Don't reset the interface on open
See: raspberrypi/linux#2437
See: raspberrypi/linux#2442
See: raspberrypi/linux#2457

firmware: clockman: Don't use OSC for pixel clock
See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=24679&start=150#p1297298
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this issue Apr 4, 2018
@popcornmix
kernel: net: lan78xx: Allow for VLAN headers in timeout
0382fa9 
See: raspberrypi/linux#2458

kernel: Revert lan78xx: Simple patch to prevent some crashes
kernel: lan78xx: Connect phy early
kernel: lan78xx: Don't reset the interface on open
See: raspberrypi/linux#2437
See: raspberrypi/linux#2442
See: raspberrypi/linux#2457

firmware: clockman: Don't use OSC for pixel clock
See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=24679&start=150#p1297298
@popcornmix
Copy link
Collaborator

Latest rpi-update kernel has a potential fix for this issue. Please test.

@graysky2
Copy link

graysky2 commented Apr 4, 2018

@popcornmix - Arch ARM doesn't use that script but I am building:

Will try and report back, thank you!

@graysky2
Copy link

graysky2 commented Apr 4, 2018 •
edited
Loading

Will try and report back, thank you!

@popcornmix - I am now able to successfully boot with the bridge setup I described in systemd/systemd#8503.

Great job!

@graysky2 graysky2 mentioned this issue Apr 4, 2018
Closed
popcornmix pushed a commit that referenced this issue Apr 8, 2018
@popcornmix
lan78xx: Don't reset the interface on open
4d926e8 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
pelwell pushed a commit that referenced this issue Apr 17, 2018
lan78xx: Don't reset the interface on open
d235661 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
pelwell pushed a commit that referenced this issue Apr 17, 2018
lan78xx: Don't reset the interface on open
ee0f3b1 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
popcornmix pushed a commit that referenced this issue Apr 26, 2018
@popcornmix
lan78xx: Don't reset the interface on open
c445a42 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
@pelwell pelwell closed this as completed Apr 30, 2018
popcornmix pushed a commit that referenced this issue May 5, 2018
@popcornmix
lan78xx: Don't reset the interface on open
24544b9 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
popcornmix pushed a commit that referenced this issue May 5, 2018
@popcornmix
lan78xx: Don't reset the interface on open
b4c8ab3 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
popcornmix pushed a commit that referenced this issue May 17, 2018
@popcornmix
lan78xx: Don't reset the interface on open
499a690 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
pelwell pushed a commit that referenced this issue May 20, 2018
lan78xx: Don't reset the interface on open
c891414 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
pelwell pushed a commit that referenced this issue May 20, 2018
lan78xx: Don't reset the interface on open
adfb274 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
popcornmix pushed a commit that referenced this issue May 21, 2018
@popcornmix
lan78xx: Don't reset the interface on open
c44827d 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
popcornmix pushed a commit that referenced this issue May 25, 2018
@popcornmix
lan78xx: Don't reset the interface on open
099c7b8 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
popcornmix pushed a commit that referenced this issue May 29, 2018
@popcornmix
lan78xx: Don't reset the interface on open
ceb25a0 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
popcornmix pushed a commit that referenced this issue Jun 5, 2018
@popcornmix
lan78xx: Don't reset the interface on open
ef10500 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
popcornmix pushed a commit that referenced this issue Jun 11, 2018
@popcornmix
lan78xx: Don't reset the interface on open
123f453 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
popcornmix pushed a commit that referenced this issue Jun 13, 2018
@popcornmix
lan78xx: Don't reset the interface on open
73ba259 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
popcornmix pushed a commit that referenced this issue Jun 18, 2018
@popcornmix
lan78xx: Don't reset the interface on open
0ee21d6 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
popcornmix pushed a commit that referenced this issue Jun 27, 2018
@popcornmix
lan78xx: Don't reset the interface on open
3ad3b8a 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
APokorny pushed a commit to ubports/ubuntu_kernel_xenial that referenced this issue Oct 11, 2018
@ksacilotto
lan78xx: Don't reset the interface on open
d2936e3 
BugLink: http://bugs.launchpad.net/bugs/1784025

With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: raspberrypi/linux#2437
     raspberrypi/linux#2442
     raspberrypi/linux#2457

Fixes: 92571a1aae40 ("lan78xx: Connect phy early")
Signed-off-by: Phil Elwell <[email protected]>
(backported from commit 47b998653fea4ef69e3e89574956386f262bccca)
Signed-off-by: Paolo Pisati <[email protected]>
Acked-by: Stefan Bader <[email protected]>
Acked-by: Kleber Sacilotto de Souza <[email protected]>
Signed-off-by: Kleber Sacilotto de Souza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@graysky2 @popcornmix @pelwell @penfold42