Skip to content

device tree: bcm2708.dts, node clocks has no lable, can't overlay clocks node #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
taudac opened this issue Feb 21, 2015 · 2 comments
Closed

Comments

@taudac
Copy link
Contributor

taudac commented Feb 21, 2015

I am developing a device driver for a HAT that has two crystal oscillators. I have made a device tree overlay file to describe the oscillators which looks like the following:

...
/ {
compatible = "brcm,bcm2708";

fragment@0 {
    target = <&clocks>;
    __overlay__ {

        osc22: [email protected] {
            compatible = "fixed-clock";
            #clock-cells = <0>;
            clock-frequency = <22579200>;
        };

        osc24: [email protected] {
            compatible = "fixed-clock";
            #clock-cells = <0>;
            clock-frequency = <24576000>;
        };
    };
};
...

Loading of this dtb file fails with the error dterror: can't find symbol 'clocks'. If I understand it correctly, this error is caused by the fact that the node clocks in the file bcm2708.dtsi has no label.

In the file bcm2708.dtsi, can we replace the line

    clocks {

by

    clocks: clocks {

?

Or am I missing something?

@pelwell
Copy link
Contributor

pelwell commented Feb 21, 2015

Try using:

target-path="/clocks";

@taudac
Copy link
Contributor Author

taudac commented Feb 21, 2015

@pelwell Thanks, using target-path="/clocks"; works.

@pelwell pelwell closed this as completed Feb 21, 2015
vanfanel referenced this issue Feb 27, 2016
This is a significant revision of the bcm2835-sdhost driver. It
improves on the original in a number of ways:

1) Through the use of CMD23 for reads it appears to avoid problems
   reading some sectors on certain high speed cards.
2) Better atomicity to prevent crashes.
3) Higher performance.
4) Activity logging included, for easier diagnosis in the event
   of a problem.
pfpacket pushed a commit to pfpacket/linux-rpi-rust that referenced this issue Apr 7, 2023
rust: use `.rsi` for macro expanded outputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants