Skip to content

device tree: bcm2708.dts, node clocks has no lable, can't overlay clocks node #845

Closed
@taudac

Description

@taudac

I am developing a device driver for a HAT that has two crystal oscillators. I have made a device tree overlay file to describe the oscillators which looks like the following:

...
/ {
compatible = "brcm,bcm2708";

fragment@0 {
    target = <&clocks>;
    __overlay__ {

        osc22: [email protected] {
            compatible = "fixed-clock";
            #clock-cells = <0>;
            clock-frequency = <22579200>;
        };

        osc24: [email protected] {
            compatible = "fixed-clock";
            #clock-cells = <0>;
            clock-frequency = <24576000>;
        };
    };
};
...

Loading of this dtb file fails with the error dterror: can't find symbol 'clocks'. If I understand it correctly, this error is caused by the fact that the node clocks in the file bcm2708.dtsi has no label.

In the file bcm2708.dtsi, can we replace the line

    clocks {

by

    clocks: clocks {

?

Or am I missing something?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions