Skip to content

bcm2708-vcio: Remove module #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 27, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion arch/arm/configs/bcm2709_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,6 @@ CONFIG_FB_TFT_WATTEROTT=m
CONFIG_FB_FLEX=m
CONFIG_FB_TFT_FBTFT_DEVICE=m
CONFIG_MAILBOX=y
CONFIG_BCM2708_MBOX=y
CONFIG_BCM2835_MBOX=y
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_EXTCON=m
Expand Down
1 change: 0 additions & 1 deletion arch/arm/configs/bcm2835_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -1064,7 +1064,6 @@ CONFIG_FB_TFT_WATTEROTT=m
CONFIG_FB_FLEX=m
CONFIG_FB_TFT_FBTFT_DEVICE=m
CONFIG_MAILBOX=y
CONFIG_BCM2708_MBOX=y
CONFIG_BCM2835_MBOX=y
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_EXTCON=m
Expand Down
1 change: 0 additions & 1 deletion arch/arm/configs/bcmrpi_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -1071,7 +1071,6 @@ CONFIG_FB_TFT_WATTEROTT=m
CONFIG_FB_FLEX=m
CONFIG_FB_TFT_FBTFT_DEVICE=m
CONFIG_MAILBOX=y
CONFIG_BCM2708_MBOX=y
CONFIG_BCM2835_MBOX=y
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_EXTCON=m
Expand Down
1 change: 0 additions & 1 deletion drivers/char/broadcom/vc_mem.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include <linux/debugfs.h>
#include <asm/uaccess.h>
#include <linux/dma-mapping.h>
#include <linux/platform_data/mailbox-bcm2708.h>
#include <linux/broadcom/vc_mem.h>

#define DRIVER_NAME "vc-mem"
Expand Down
2 changes: 1 addition & 1 deletion drivers/cpufreq/Kconfig.arm
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ config ARM_SPEAR_CPUFREQ
This adds the CPUFreq driver support for SPEAr SOCs.

config ARM_BCM2835_CPUFREQ
depends on BCM2708_MBOX
depends on RASPBERRYPI_FIRMWARE
bool "BCM2835 Driver"
default y
help
Expand Down
15 changes: 2 additions & 13 deletions drivers/firmware/raspberrypi.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,13 @@
#define MBOX_MSG(chan, data28) (((data28) & ~0xf) | ((chan) & 0xf))
#define MBOX_CHAN(msg) ((msg) & 0xf)
#define MBOX_DATA28(msg) ((msg) & ~0xf)
#define MBOX_CHAN_VCHIQ 3
#define MBOX_CHAN_PROPERTY 8

struct rpi_firmware {
struct mbox_client cl;
struct mbox_chan *chan; /* The property channel. */
struct completion c;
u32 enabled;
u32 received;
};

static struct platform_device *g_pdev;
Expand All @@ -37,15 +35,14 @@ static DEFINE_MUTEX(transaction_lock);
static void response_callback(struct mbox_client *cl, void *msg)
{
struct rpi_firmware *fw = container_of(cl, struct rpi_firmware, cl);
fw->received = *(u32 *)msg;
complete(&fw->c);
}

/*
* Sends a request to the firmware through the BCM2835 mailbox driver,
* and synchronously waits for the reply.
*/
int
static int
rpi_firmware_transaction(struct rpi_firmware *fw, u32 chan, u32 data)
{
u32 message = MBOX_MSG(chan, data);
Expand All @@ -57,8 +54,7 @@ rpi_firmware_transaction(struct rpi_firmware *fw, u32 chan, u32 data)
reinit_completion(&fw->c);
ret = mbox_send_message(fw->chan, &message);
if (ret >= 0) {
if (chan != MBOX_CHAN_VCHIQ)
wait_for_completion(&fw->c);
wait_for_completion(&fw->c);
ret = 0;
} else {
dev_err(fw->cl.dev, "mbox_send_message returned %d\n", ret);
Expand All @@ -67,13 +63,6 @@ rpi_firmware_transaction(struct rpi_firmware *fw, u32 chan, u32 data)

return ret;
}
EXPORT_SYMBOL(rpi_firmware_transaction);

u32 rpi_firmware_transaction_received(struct rpi_firmware *fw)
{
return MBOX_DATA28(fw->received);
}
EXPORT_SYMBOL(rpi_firmware_transaction_received);

/**
* rpi_firmware_property_list - Submit firmware property list
Expand Down
2 changes: 1 addition & 1 deletion drivers/input/touchscreen/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ config TOUCHSCREEN_EDT_FT5X06

config TOUCHSCREEN_RPI_FT5406
tristate "Raspberry Pi FT5406 driver"
depends on ARCH_BCM2708 || ARCH_BCM2709
depends on RASPBERRYPI_FIRMWARE
help
Say Y here to enable the Raspberry Pi memory based FT5406 device

Expand Down
6 changes: 0 additions & 6 deletions drivers/mailbox/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,6 @@ menuconfig MAILBOX

if MAILBOX

config BCM2708_MBOX
bool "Broadcom BCM2708 Mailbox (vcio)"
depends on BCM2835_MBOX
help
Broadcom BCM2708 Mailbox (vcio)

config ARM_MHU
tristate "ARM MHU Mailbox"
depends on ARM_AMBA
Expand Down
2 changes: 0 additions & 2 deletions drivers/mailbox/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

obj-$(CONFIG_MAILBOX) += mailbox.o

obj-$(CONFIG_BCM2708_MBOX) += bcm2708-vcio.o

obj-$(CONFIG_ARM_MHU) += arm_mhu.o

obj-$(CONFIG_PL320_MBOX) += pl320-ipc.o
Expand Down
86 changes: 0 additions & 86 deletions drivers/mailbox/bcm2708-vcio.c

This file was deleted.

2 changes: 1 addition & 1 deletion drivers/misc/vc04_services/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
config BCM2708_VCHIQ
tristate "Videocore VCHIQ"
depends on (MACH_BCM2708 || MACH_BCM2709 || ARCH_BCM2835) && BCM2708_MBOX
depends on RASPBERRYPI_FIRMWARE
default y
help
Kernel to VideoCore communication interface for the
Expand Down
2 changes: 1 addition & 1 deletion drivers/thermal/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ config INTEL_POWERCLAMP
user interface is exposed via generic thermal framework.

config THERMAL_BCM2835
depends on BCM2708_MBOX
depends on RASPBERRYPI_FIRMWARE
tristate "BCM2835 Thermal Driver"
help
This will enable temperature monitoring for the Broadcom BCM2835
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/fbdev/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ comment "Frame buffer hardware drivers"

config FB_BCM2708
tristate "BCM2708 framebuffer support"
depends on FB && ARM && BCM2708_MBOX
depends on FB && RASPBERRYPI_FIRMWARE
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
Expand Down
127 changes: 0 additions & 127 deletions include/linux/platform_data/mailbox-bcm2708.h

This file was deleted.

2 changes: 0 additions & 2 deletions include/soc/bcm2835/raspberrypi-firmware.h
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ enum rpi_firmware_property_tag {
RPI_FIRMWARE_GET_DMA_CHANNELS = 0x00060001,
};

int rpi_firmware_transaction(struct rpi_firmware *fw, u32 chan, u32 data);
u32 rpi_firmware_transaction_received(struct rpi_firmware *fw);
int rpi_firmware_property(struct rpi_firmware *fw,
u32 tag, void *data, size_t len);
int rpi_firmware_property_list(struct rpi_firmware *fw,
Expand Down