Skip to content

dwc_otg: fiq_fsm: Make high-speed isochronous strided transfers work properly #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2015

Conversation

P33M
Copy link
Contributor

@P33M P33M commented Aug 4, 2015

Fixes playback on my Schitt Modi 2 audio box.

Should fix the root cause identified in #888.

@@ -1692,9 +1695,11 @@ int fiq_fsm_queue_isoc_transaction(dwc_otg_hcd_t *hcd, dwc_otg_qh_t *qh)
DWC_WRITE_REG32(&hc_regs->hcintmsk, st->hcintmsk_copy.d32);
if (hfnum.b.frrem < PERIODIC_FRREM_BACKOFF) {
/* Prevent queueing near EOF1. Bad things happen if a periodic
* split transaction is queued very close to EOF.
* split transaction is queued very close to EOF. SOF interrupt handler
* will wake this channel at the next interrupt. *

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental leftover: <SPACE> *

…properly

Certain low-bandwidth high-speed USB devices (specialist audio devices,
compressed-frame webcams) have packet intervals > 1 microframe.

Stride these transfers in the FIQ by using the start-of-frame interrupt
to restart the channel at the right time.
popcornmix added a commit that referenced this pull request Aug 4, 2015
dwc_otg: fiq_fsm: Make high-speed isochronous strided transfers work properly
@popcornmix popcornmix merged commit 9896b02 into raspberrypi:rpi-4.1.y Aug 4, 2015
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Aug 6, 2015
kernel: dwc_otg: fiq_fsm: Make high-speed isochronous strided transfers work properly
See: raspberrypi/linux#1094
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Aug 6, 2015
kernel: dwc_otg: fiq_fsm: Make high-speed isochronous strided transfers work properly
See: raspberrypi/linux#1094
neuschaefer pushed a commit to neuschaefer/raspi-binary-firmware that referenced this pull request Feb 27, 2017
kernel: dwc_otg: fiq_fsm: Make high-speed isochronous strided transfers work properly
See: raspberrypi/linux#1094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants