Fix I2S issues with bcm2835-dma #1160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set dreq to slave_id if it is not set like in bcm2708-dmaengine.
Transfers larger than 32k cause repeated clicking with I2S soundcards. The exact reason is yet unknown, so limit to 32k as bcm2708-dmaengine did as an intermediate fix.
Merged
|
Looks good, thanks @HiassofT |
popcornmix
added a commit
that referenced
this pull request
Oct 11, 2015
Fix I2S issues with bcm2835-dma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dreq setup was missing for slave transfers and for some (yet unknown) reason transfer sizes larger than 32k cause repated clicking on I2S soundcards.
These changes bring bcm2835-dma in line with bcm2708-dmaengine, but only limit cyclic lite transfers to 32k - other lite transfers can still use 64k-4.
See also discussion in #1153
ping @notro