Revert "bcm2835-dma: Fix dreq not set for slave transfers" #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popcornmix
force-pushed
the
rpi-4.4.y
branch
from
9faebbe to
8353706
Compare
HiassofT
force-pushed
the
revert-slaveid-4.4
branch
from
e4fb0fc to
11f8dfd
Compare
popcornmix
force-pushed
the
rpi-4.4.y
branch
from
8353706 to
e06d5b1
Compare
HiassofT
force-pushed
the
revert-slaveid-4.4
branch
from
11f8dfd to
6df3c5f
Compare
popcornmix
force-pushed
the
rpi-4.4.y
branch
from
81d8a70 to
12c2b6c
Compare
popcornmix
force-pushed
the
rpi-4.4.y
branch
2 times, most recently
from
7e5b687 to
c5cbb66
Compare
popcornmix
force-pushed
the
rpi-4.4.y
branch
3 times, most recently
from
7c37c76 to
d171758
Compare
|
@HiassofT Is this still wanted? Can you rebase? |
This reverts commit 8ad957e. DMA channels are set in devicetree, thus dreq will be set, and this commit is no longer needed. Signed-off-by: Matthias Reichl <[email protected]>
HiassofT
force-pushed
the
revert-slaveid-4.4
branch
from
6df3c5f to
0cf9d57
Compare
|
Yes, it's still wanted. The underlying issue has been fixed for some time and that means you can get rid of another downstream commit. |
|
Thanks - removing downstream commits is good. I'm sure someone will let us know if there is a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added the dreq setup at a time when the I2S dma channels were not defined in the devicetree. DMA channels are defined in DT since 96e6962 and this code doesn't seem to be needed anymore - I2S cards work fine with the code reverted.
ping @notro @pelwell could you verify if this is correct?