-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Rpi 4.4.y: HDMI hotplug detection, overlay cleanup #1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@pelwell are you happy with DT changes? |
Yes, apart from the fact that the pixelvalve2 node is enabled by default. The overlay already contains the necessary status="okay" to enable it, so I just want a single line added. |
This should clarify what's going on with the overlay: The hardware is always present, we're just enabling the DT node so that the vc4 driver probes. The interrupts are left in the overlay, because the firmware doesn't check node status before masking out the vc4 interrupts. By having the nodes in the common file, we'll be able to correctly connect the HDMI HPD GPIO so that we can detect whether an HDMI monitor is connected. Signed-off-by: Eric Anholt <[email protected]>
The CM is left out, because I haven't found a source for how the CM's HPD is connected. Signed-off-by: Eric Anholt <[email protected]>
Now that we have the HDMI HPD GPIOs correctly identified in the DT, we should be able to successfully detect HDMI. This reverts commit fbec01e. Signed-off-by: Eric Anholt <[email protected]>
Re-pushed the branch with pixelvalve fixed up. |
Looks good to me. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 13, 2016
kernel: adau1977-adc: Add basic machine driver for adau1977 codec driver See: raspberrypi/linux#1454 kernel: Allow up to 24dB digital gain to be applied when using IQAudIO DAC See: raspberrypi/linux#1458 kernel: config: Add CONFIG_DRM_LOAD_EDID_FIRMWARE See: raspberrypi/linux#1456 kernel: Rpi 4.4.y: HDMI hotplug detection, overlay cleanup See: raspberrypi/linux#1457 kernel: BCM270X_DT: Add umbrella I2C Mux overlay i2c-mux See: raspberrypi/linux#1465 kernel: BCM270X_DT: Fix the tinylcd35 overlay RTC support firmware: ldconfig: Support filter based on gpio level firmware: ldconfig: Allow specifying a overlay_prefix from config.txt See: #593 firmware: dispmanx: Avoid dispmanx updates when running vc4-kms-v3d driver See: #595 firmware: RIL Camera: Correct buffer size checking for RGB and BGR888 firmware: RIL video_encode: Add support for levels 4.1 and 4.2 firmware: IMX219: Add assert on failure to init firmware: imx219: New VGA and full FOV 720p modes firmware: imx219: Reorder modes to roughly match OV5647 firmware: imx219: Enable sensor DPC See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=145815
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
May 13, 2016
kernel: adau1977-adc: Add basic machine driver for adau1977 codec driver See: raspberrypi/linux#1454 kernel: Allow up to 24dB digital gain to be applied when using IQAudIO DAC See: raspberrypi/linux#1458 kernel: config: Add CONFIG_DRM_LOAD_EDID_FIRMWARE See: raspberrypi/linux#1456 kernel: Rpi 4.4.y: HDMI hotplug detection, overlay cleanup See: raspberrypi/linux#1457 kernel: BCM270X_DT: Add umbrella I2C Mux overlay i2c-mux See: raspberrypi/linux#1465 kernel: BCM270X_DT: Fix the tinylcd35 overlay RTC support firmware: ldconfig: Support filter based on gpio level firmware: ldconfig: Allow specifying a overlay_prefix from config.txt See: raspberrypi/firmware#593 firmware: dispmanx: Avoid dispmanx updates when running vc4-kms-v3d driver See: raspberrypi/firmware#595 firmware: RIL Camera: Correct buffer size checking for RGB and BGR888 firmware: RIL video_encode: Add support for levels 4.1 and 4.2 firmware: IMX219: Add assert on failure to init firmware: imx219: New VGA and full FOV 720p modes firmware: imx219: Reorder modes to roughly match OV5647 firmware: imx219: Enable sensor DPC See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=145815
neuschaefer
pushed a commit
to neuschaefer/raspi-binary-firmware
that referenced
this pull request
Feb 27, 2017
kernel: adau1977-adc: Add basic machine driver for adau1977 codec driver See: raspberrypi/linux#1454 kernel: Allow up to 24dB digital gain to be applied when using IQAudIO DAC See: raspberrypi/linux#1458 kernel: config: Add CONFIG_DRM_LOAD_EDID_FIRMWARE See: raspberrypi/linux#1456 kernel: Rpi 4.4.y: HDMI hotplug detection, overlay cleanup See: raspberrypi/linux#1457 kernel: BCM270X_DT: Add umbrella I2C Mux overlay i2c-mux See: raspberrypi/linux#1465 kernel: BCM270X_DT: Fix the tinylcd35 overlay RTC support firmware: ldconfig: Support filter based on gpio level firmware: ldconfig: Allow specifying a overlay_prefix from config.txt See: raspberrypi#593 firmware: dispmanx: Avoid dispmanx updates when running vc4-kms-v3d driver See: raspberrypi#595 firmware: RIL Camera: Correct buffer size checking for RGB and BGR888 firmware: RIL video_encode: Add support for levels 4.1 and 4.2 firmware: IMX219: Add assert on failure to init firmware: imx219: New VGA and full FOV 720p modes firmware: imx219: Reorder modes to roughly match OV5647 firmware: imx219: Enable sensor DPC See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=145815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally got a rework of the overlay to work (mostly just irritating debug from overlays not validating well and silently failing to apply at runtime), so I could get HDMI hotplug detection fixed. The commits on this branch should apply to 4.5.y as well.