-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add an overlay for the Ti ADS1015 A/D #1504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That's a good attempt, but you'd be better off doing something like this. It uses the exported symbol Note that If your channel numbers are arbitrary then I think it would be less confusing to either make the default numbers match your virtual channel names, i.e. 1-4, or use letters for your virtual channels. In order to be accepted you will also need to add your overlay to the Makefile and README - observe the strict formatting (80 columns, no TABs) and alphabetical order rules. |
Merge Current RPI Kernel
…lias as the target and relative path for the fragments
Phil, |
@@ -167,6 +167,27 @@ Info: Overlay for activation of ADAU1977 ADC codec over I2C for control | |||
Load: dtoverlay=adau1977-adc | |||
Params: <None> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add another blank line here.
Address the comments above, squash the commits down to one (use |
Having problems squashing this, when I caught up my fork there ended up being a few hundred commits between my first commit and my later commits. I'm just going to close this and re-open it with everything as one big commit |
I created this for a project I did recently. This overlay works with the existing ads1015 hwmon kernel driver. I tried to make it as flexible as possible, making most options configurable via config.txt.
I would have liked to target the alias "i2c_arm" rather then the exact path with the memory address but I could not get the enabling/disabling of fragments to work properly as I could not seem to target a previous fragment with a later one. This is my first device tree overlay so there may be a way to do that which I am not aware of.
I created a README.md in my repo for it: https://github.com/eriksejr/rpi_ads1015
Feedback is welcome.