Implement a "wakeup-source" option for the i2c-rtc DeviceTree overlay. #1511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that this is a parameter which will do nothing if not used, I'm prepared to take the chance that it won't work. I would, though, like an explanation of "wakeup-source" in the README. |
| @@ -65,5 +65,9 @@ | |||
| pcf8523 = <&pcf8523>,"status"; | |||
| pcf8563 = <&pcf8563>,"status"; | |||
| trickle-resistor-ohms = <&ds1339>,"trickle-resistor-ohms:0"; | |||
| wakeup-source = <&ds1339>,"wakeup-source?", | |||
| <&ds3231>,"wakeup-source?", | |||
| <&mcp7940x>,"wakeup-source?"; | |||
There was a problem hiding this comment.
The semicolon on this line should be a comma.
|
Thanks for your comment. I just pushed a fixed commit to my rpi-4.4.y branch, but can’t figure out how to update my pull request. (Sorry, still quite new to git…) |
pelwell
pushed a commit
that referenced
this pull request
Jun 5, 2016
|
The README entry contained a line which was too long (there's an 80 character limit), but I've corrected that and merged it manually. |
|
Sorry @pelwell for not figuring out the 80-character limit, and thanks for your merge. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jun 8, 2016
kernel: Add ads1015 overlay See: raspberrypi/linux#1520 kernel: brcmfmac: change rx_seq check log from error print to debug print See: raspberrypi/linux#1313 kernel: brcmfmac: use ndev->needed_headroom to reserve additional header space See: raspberrypi/linux#1357 kernel: brcmfmac: revise SDIO error message in brcmf_sdio_drivestrengthinit kernel: BCM270X_DT: Make i2c-gpio usable by other overlays kernel: BCM270X_DT: Fix rpi-dac overlay See: http://forum.kodi.tv/showthread.php?tid=269814&pid=2349776#pid2349776 kernel: Implement a wakeup-source option for the i2c-rtc DeviceTree overlay See: raspberrypi/linux#1511 kernel: gpio-ir-receiver: fix overlay and add upstream patches See: raspberrypi/linux#1514 firmware: Tuner: Disable unused ACLS tuner, and improve logging firmware: imx219: Remove static variable firmware: ISP Tuners: Make DPF parsing thread safe firmware: audioplus: Allow passthrough dma priority to be overridden in same way as pcm firmware: di_adv: Remove delay uniform firmeare: di_adv: Enable limiter and tweak axi priorities
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Jun 8, 2016
kernel: Add ads1015 overlay See: raspberrypi/linux#1520 kernel: brcmfmac: change rx_seq check log from error print to debug print See: raspberrypi/linux#1313 kernel: brcmfmac: use ndev->needed_headroom to reserve additional header space See: raspberrypi/linux#1357 kernel: brcmfmac: revise SDIO error message in brcmf_sdio_drivestrengthinit kernel: BCM270X_DT: Make i2c-gpio usable by other overlays kernel: BCM270X_DT: Fix rpi-dac overlay See: http://forum.kodi.tv/showthread.php?tid=269814&pid=2349776#pid2349776 kernel: Implement a wakeup-source option for the i2c-rtc DeviceTree overlay See: raspberrypi/linux#1511 kernel: gpio-ir-receiver: fix overlay and add upstream patches See: raspberrypi/linux#1514 firmware: Tuner: Disable unused ACLS tuner, and improve logging firmware: imx219: Remove static variable firmware: ISP Tuners: Make DPF parsing thread safe firmware: audioplus: Allow passthrough dma priority to be overridden in same way as pcm firmware: di_adv: Remove delay uniform firmeare: di_adv: Enable limiter and tweak axi priorities
pelwell
pushed a commit
that referenced
this pull request
Jun 9, 2016
popcornmix
pushed a commit
that referenced
this pull request
Jun 21, 2016
popcornmix
pushed a commit
that referenced
this pull request
Jun 26, 2016
popcornmix
pushed a commit
that referenced
this pull request
Jun 26, 2016
popcornmix
pushed a commit
that referenced
this pull request
Jul 12, 2016
popcornmix
pushed a commit
that referenced
this pull request
Jul 25, 2016
popcornmix
pushed a commit
that referenced
this pull request
Jul 28, 2016
popcornmix
pushed a commit
that referenced
this pull request
Aug 12, 2016
popcornmix
pushed a commit
that referenced
this pull request
Aug 19, 2016
ColinIanKing
pushed a commit
to ColinIanKing/ubuntu-xenial
that referenced
this pull request
Oct 28, 2016
angyalp
pushed a commit
to angyalp/kernel_rpi
that referenced
this pull request
Dec 19, 2016
tabp0le
pushed a commit
to tabp0le/ubuntu_xenial_kernel
that referenced
this pull request
Dec 22, 2016
perfecto-devops
pushed a commit
to perfecto-devops/ubuntu-xenial
that referenced
this pull request
Feb 2, 2017
Noltari
pushed a commit
to Noltari/linux
that referenced
this pull request
Feb 6, 2017
neuschaefer
pushed a commit
to neuschaefer/raspi-binary-firmware
that referenced
this pull request
Feb 27, 2017
kernel: Add ads1015 overlay See: raspberrypi/linux#1520 kernel: brcmfmac: change rx_seq check log from error print to debug print See: raspberrypi/linux#1313 kernel: brcmfmac: use ndev->needed_headroom to reserve additional header space See: raspberrypi/linux#1357 kernel: brcmfmac: revise SDIO error message in brcmf_sdio_drivestrengthinit kernel: BCM270X_DT: Make i2c-gpio usable by other overlays kernel: BCM270X_DT: Fix rpi-dac overlay See: http://forum.kodi.tv/showthread.php?tid=269814&pid=2349776#pid2349776 kernel: Implement a wakeup-source option for the i2c-rtc DeviceTree overlay See: raspberrypi/linux#1511 kernel: gpio-ir-receiver: fix overlay and add upstream patches See: raspberrypi/linux#1514 firmware: Tuner: Disable unused ACLS tuner, and improve logging firmware: imx219: Remove static variable firmware: ISP Tuners: Make DPF parsing thread safe firmware: audioplus: Allow passthrough dma priority to be overridden in same way as pcm firmware: di_adv: Remove delay uniform firmeare: di_adv: Enable limiter and tweak axi priorities
JackieLiu1
pushed a commit
to JackieLiu1/kernel
that referenced
this pull request
Mar 23, 2017
woshihuangzhijie
pushed a commit
to woshihuangzhijie/linuxcode
that referenced
this pull request
Sep 20, 2017
amichelotti
pushed a commit
to amichelotti/ubuntu-vme-xenial
that referenced
this pull request
Oct 19, 2017
lianhaidong
pushed a commit
to lianhaidong/ubuntu-xenial
that referenced
this pull request
Nov 6, 2017
liuqun
pushed a commit
to liuqun/linux-raspi2
that referenced
this pull request
Dec 14, 2017
liuqun
pushed a commit
to liuqun/linux-raspi2
that referenced
this pull request
Dec 20, 2017
liuqun
pushed a commit
to liuqun/linux-raspi2
that referenced
this pull request
Dec 20, 2017
polceanum
pushed a commit
to polceanum/ubuntu-xenial
that referenced
this pull request
Feb 6, 2018
APokorny
pushed a commit
to ubports/ubuntu_kernel_xenial
that referenced
this pull request
Oct 11, 2018
hisenyiu2015
pushed a commit
to hisenyiu2015/msm-4.14
that referenced
this pull request
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch was already discussed at [https://github.com//pull/1260#issuecomment-204966308].
Unfortunately, I have not had the opportunity yet to test it myself with the latest firmware.