fix auto-sense in lirc_rpi driver #1581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a Raspberry Pi 2, the lirc_rpi driver might receive spurious interrupts and change it's low-active / high-active setting. When this happens, the IR remote control stops working. This patch disables this auto-detection if the 'sense' parameter was set in the device tree, making the driver robust to such spurious interrupts.
|
Looks okay to me. @pelwell okay with you? |
|
I don't understand the failure mechanism - if a spuriously long pulse is interpreted as an inverted space, causing the sense to be inverted, the following real space (which is seen as a long pulse) should cause the sense to flip back again, unless in normal use you never see a long space - but I see no problem with the patch. |
|
Hmm, occasionally the sense bit did flip back after a while - probably at the first signal after 15 seconds of complete 'silence'. I'm not 100% sure if that explained all error cases that I encountered, but with this fix my remote control worked very reliably. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Aug 10, 2016
See: raspberrypi/linux#1581 kernel: enable gembird joypad support See: raspberrypi/linux#1589 kernel: Added HiFiBerry Digi+ Pro driver See: raspberrypi/linux#1583 kernel: overlays: Add assert_falling_edge to pps-gpio overlay See: raspberrypi/linux#1590 kernel: Experimental graphics driver DSI support See: raspberrypi/linux#1556 firmware: Add customisation project board type firmware: platform: Enable Bluetooth on custom firmware: gencmd: Add support for hdmi_cvt and hdmi_timings See: #637 firmware: arm_display: Allow source aspect ratio to be configured See: #638 firmware: mmal: Allow /dev/vchiq to be opened initialised prior to mmal_vc_init
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Aug 10, 2016
See: raspberrypi/linux#1581 kernel: enable gembird joypad support See: raspberrypi/linux#1589 kernel: Added HiFiBerry Digi+ Pro driver See: raspberrypi/linux#1583 kernel: overlays: Add assert_falling_edge to pps-gpio overlay See: raspberrypi/linux#1590 kernel: Experimental graphics driver DSI support See: raspberrypi/linux#1556 firmware: Add customisation project board type firmware: platform: Enable Bluetooth on custom firmware: gencmd: Add support for hdmi_cvt and hdmi_timings See: raspberrypi/firmware#637 firmware: arm_display: Allow source aspect ratio to be configured See: raspberrypi/firmware#638 firmware: mmal: Allow /dev/vchiq to be opened initialised prior to mmal_vc_init
mkreisl
added a commit
to xbianonpi/xbian-package-firmware
that referenced
this pull request
Aug 12, 2016
- kernel: fix auto-sense in lirc_rpi driver See: raspberrypi/linux#1581 - kernel: enable gembird joypad support See: raspberrypi/linux#1589 - kernel: Added HiFiBerry Digi+ Pro driver See: raspberrypi/linux#1583 - kernel: overlays: Add assert_falling_edge to pps-gpio overlay See: raspberrypi/linux#1590 - kernel: Experimental graphics driver DSI support See: raspberrypi/linux#1556 - firmware: Add customisation project board type - firmware: platform: Enable Bluetooth on custom - firmware: gencmd: Add support for hdmi_cvt and hdmi_timings See: #637 - firmware: arm_display: Allow source aspect ratio to be configured See: #638 - firmware: mmal: Allow /dev/vchiq to be opened initialised prior to mmal_vc_init
neuschaefer
pushed a commit
to neuschaefer/raspi-binary-firmware
that referenced
this pull request
Feb 27, 2017
See: raspberrypi/linux#1581 kernel: enable gembird joypad support See: raspberrypi/linux#1589 kernel: Added HiFiBerry Digi+ Pro driver See: raspberrypi/linux#1583 kernel: overlays: Add assert_falling_edge to pps-gpio overlay See: raspberrypi/linux#1590 kernel: Experimental graphics driver DSI support See: raspberrypi/linux#1556 firmware: Add customisation project board type firmware: platform: Enable Bluetooth on custom firmware: gencmd: Add support for hdmi_cvt and hdmi_timings See: raspberrypi#637 firmware: arm_display: Allow source aspect ratio to be configured See: raspberrypi#638 firmware: mmal: Allow /dev/vchiq to be opened initialised prior to mmal_vc_init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope this is the right branch - anyway, the lirc_rpi driver didn't change too much recently.
This reliably fixed my problems with infrared remote controls.
On a Raspberry Pi 2, the lirc_rpi driver might receive spurious
interrupts and change it's low-active / high-active setting.
When this happens, the IR remote control stops working.
This patch disables this auto-detection if the 'sense' parameter
was set in the device tree, making the driver robust to such
spurious interrupts.