Skip to content

Correct typos in spi-gpio35-39-overlay.dts #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2016

Conversation

evaporatingtime
Copy link

bcrm,pins corrected to brcm,pins

bcrm,pins corrected to brcm,pins
@pelwell pelwell merged commit 1db92c6 into raspberrypi:rpi-4.4.y Sep 23, 2016
@pelwell
Copy link
Contributor

pelwell commented Sep 23, 2016

Thanks - well spotted.

pelwell pushed a commit that referenced this pull request Sep 23, 2016
bcrm,pins corrected to brcm,pins
pelwell pushed a commit that referenced this pull request Sep 23, 2016
bcrm,pins corrected to brcm,pins
popcornmix pushed a commit that referenced this pull request Sep 24, 2016
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Sep 26, 2016
kernel: Allo Piano DAC boards: Initial 2 channel (stereo) support
See: raspberrypi/linux#1645

kernel: Correct typos in spi-gpio35-39-overlay.dts
See: raspberrypi/linux#1651

kernel: drm/vc4: Enable limited range RGB output with CEA modes

kernel: brcmfmac: Change stop_ap sequence
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Sep 26, 2016
kernel: Allo Piano DAC boards: Initial 2 channel (stereo) support
See: raspberrypi/linux#1645

kernel: Correct typos in spi-gpio35-39-overlay.dts
See: raspberrypi/linux#1651

kernel: drm/vc4: Enable limited range RGB output with CEA modes

kernel: brcmfmac: Change stop_ap sequence
popcornmix pushed a commit that referenced this pull request Sep 29, 2016
popcornmix pushed a commit that referenced this pull request Sep 30, 2016
popcornmix pushed a commit that referenced this pull request Oct 3, 2016
popcornmix pushed a commit that referenced this pull request Oct 9, 2016
popcornmix pushed a commit that referenced this pull request Oct 17, 2016
leeminghao pushed a commit to yudatun/vendor_raspberrypi_firmware that referenced this pull request Oct 18, 2016
kernel: Allo Piano DAC boards: Initial 2 channel (stereo) support
See: raspberrypi/linux#1645

kernel: Correct typos in spi-gpio35-39-overlay.dts
See: raspberrypi/linux#1651

kernel: drm/vc4: Enable limited range RGB output with CEA modes

kernel: brcmfmac: Change stop_ap sequence
popcornmix pushed a commit that referenced this pull request Oct 22, 2016
angyalp pushed a commit to angyalp/kernel_rpi that referenced this pull request Dec 19, 2016
popcornmix pushed a commit that referenced this pull request Mar 13, 2018
Commit 6de3f79 ("arm_pmu: explicitly enable/disable SPIs at hotplug")
moved all of the arm_pmu IRQ enable/disable calls to the CPU hotplug hooks,
regardless of whether they are implemented as PPIs or SPIs. This can
lead to us sleeping from atomic context due to disable_irq blocking:

 | BUG: sleeping function called from invalid context at kernel/irq/manage.c:112
 | in_atomic(): 1, irqs_disabled(): 128, pid: 15, name: migration/1
 | no locks held by migration/1/15.
 | irq event stamp: 192
 | hardirqs last  enabled at (191): [<00000000803c2507>]
 | _raw_spin_unlock_irq+0x2c/0x4c
 | hardirqs last disabled at (192): [<000000007f57ad28>] multi_cpu_stop+0x9c/0x140
 | softirqs last  enabled at (0): [<0000000004ee1b58>]
 | copy_process.isra.77.part.78+0x43c/0x1504
 | softirqs last disabled at (0): [<          (null)>]           (null)
 | CPU: 1 PID: 15 Comm: migration/1 Not tainted 4.16.0-rc3-salvator-x #1651
 | Hardware name: Renesas Salvator-X board based on r8a7796 (DT)
 | Call trace:
 |  dump_backtrace+0x0/0x140
 |  show_stack+0x14/0x1c
 |  dump_stack+0xb4/0xf0
 |  ___might_sleep+0x1fc/0x218
 |  __might_sleep+0x70/0x80
 |  synchronize_irq+0x40/0xa8
 |  disable_irq+0x20/0x2c
 |  arm_perf_teardown_cpu+0x80/0xac

Since the interrupt is always CPU-affine and this code is running with
interrupts disabled, we can just use disable_irq_nosync as we know there
isn't a concurrent invocation of the handler to worry about.

Fixes: 6de3f79 ("arm_pmu: explicitly enable/disable SPIs at hotplug")
Reported-by: Geert Uytterhoeven <[email protected]>
Tested-by: Geert Uytterhoeven <[email protected]>
Acked-by: Mark Rutland <[email protected]>
Signed-off-by: Will Deacon <[email protected]>
Signed-off-by: Catalin Marinas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants