V4L2 tweaks, and GPIO expander driver #1852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H264 header come off VC with 0 timestamps, which means they get a strange timestamp when processed with VC/kernel start times, particularly if used with the inline header option. Remember the last frame timestamp and use that if set, or otherwise use the kernel start time. raspberrypi#1836 Signed-off-by: Dave Stevenson <[email protected]>
Forward MMAL key frame flags to the V4L2 buffers. Signed-off-by: Dave Stevenson <[email protected]>
Pi3 and Compute Module 3 have a GPIO expander that the VPU communicates with. There is a mailbox service that now allows control of this expander, so add a kernel driver that can make use of it. Pwr_led node added to device-tree for Pi3. Signed-off-by: Dave Stevenson <[email protected]>
|
@popcornmix Happy to merge? |
|
@6by9: Any plans to send the expander driver upstream? I know video on the RPI 3 is quite broken at the moment since HDMI connection detection isn't possible. For upstream testing, I've had to rely on the trick that simplefb gets loaded first and keep vc4 out of the config. Either that, or hack the vc4 driver to fake an always connected connection. |
I had no real intentions of submitting upstream, but I'd hope it was in a state that can be accepted without too much change. I was going to send a message to the rpi-linux list once this was merged just to say it was available and let them make the call over it. |
|
@pelwell Anything else you want to see in here? You've already reviewed the GPIO driver. |
|
I couldn't really comment on the v4l2 changes, but with @JamesH65 behind it how could I say no? |
|
OK, I'm happy to wait on popcornmix to have a quick look at the V4L2 changes. |
|
Ping @popcornmix. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Mar 1, 2017
kernel: BCM2835-V4L2: Correctly denote key frames in encoded data kernel: bcm2835-gpio-exp: Driver for GPIO expander via mailbox service See: raspberrypi/linux#1852 kernel: Add overlay for ads1115 ADCs See: raspberrypi/linux#1864 kernel: Add support for Fe-Pi audio sound card See: raspberrypi/linux#1867 kernel: amba_pl011: Round input clock up kernel: clk-bcm2835: Correct the prediv logic firmware: Redo CEC code cleanup 3: Removed CEC topology computation firmware: Redo CEC code cleanup 4: Removed unused functions firmware: Redo CEC code cleanup 5: Removed Rx processing firmware: Redo CEC code cleanup 6: Logging changed to VCOS firmware: Redo CEC code cleanup 7: Removed hdmi_state_machine_clock_changed firmware: Redo CEC code cleanup 8: fixed hdmi state machine clk firmware: Redo CEC code cleanup 10: misc cosmetic changes firmware: Fixup CEC code cleanup 8: fixed hdmi state machine clk firmware: hdmi: Add way of forcing logging for hdmi and cec from boot firmware: Redo CEC code cleanup 11: cec_release_logical_addr firmware: arm_loader: Respect smsc95xx.macaddr parameter See: raspberrypi/linux#1865 firmware: vec: Fix progressive scan composite mode See: #683 firmware: vec: PAL_M mode is 525/60 See: #756 firmware: IL ISP: Support Bayer firmware: IL ISP: Fix error in stride calcs for YUYV formats firmware: video_render: buffer size fixup for ARGB888 firmware: video_render: Support per-pixel alpha on RGBA input See: waveform80/picamera#199
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Mar 1, 2017
kernel: BCM2835-V4L2: Correctly denote key frames in encoded data kernel: bcm2835-gpio-exp: Driver for GPIO expander via mailbox service See: raspberrypi/linux#1852 kernel: Add overlay for ads1115 ADCs See: raspberrypi/linux#1864 kernel: Add support for Fe-Pi audio sound card See: raspberrypi/linux#1867 kernel: amba_pl011: Round input clock up kernel: clk-bcm2835: Correct the prediv logic firmware: Redo CEC code cleanup 3: Removed CEC topology computation firmware: Redo CEC code cleanup 4: Removed unused functions firmware: Redo CEC code cleanup 5: Removed Rx processing firmware: Redo CEC code cleanup 6: Logging changed to VCOS firmware: Redo CEC code cleanup 7: Removed hdmi_state_machine_clock_changed firmware: Redo CEC code cleanup 8: fixed hdmi state machine clk firmware: Redo CEC code cleanup 10: misc cosmetic changes firmware: Fixup CEC code cleanup 8: fixed hdmi state machine clk firmware: hdmi: Add way of forcing logging for hdmi and cec from boot firmware: Redo CEC code cleanup 11: cec_release_logical_addr firmware: arm_loader: Respect smsc95xx.macaddr parameter See: raspberrypi/linux#1865 firmware: vec: Fix progressive scan composite mode See: raspberrypi/firmware#683 firmware: vec: PAL_M mode is 525/60 See: raspberrypi/firmware#756 firmware: IL ISP: Support Bayer firmware: IL ISP: Fix error in stride calcs for YUYV formats firmware: video_render: buffer size fixup for ARGB888 firmware: video_render: Support per-pixel alpha on RGBA input See: waveform80/picamera#199
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Mar 1, 2017
kernel: BCM2835-V4L2: Correctly denote key frames in encoded data kernel: bcm2835-gpio-exp: Driver for GPIO expander via mailbox service See: raspberrypi/linux#1852 kernel: Add overlay for ads1115 ADCs See: raspberrypi/linux#1864 kernel: Add support for Fe-Pi audio sound card See: raspberrypi/linux#1867 kernel: amba_pl011: Round input clock up kernel: clk-bcm2835: Correct the prediv logic firmware: Redo CEC code cleanup 3: Removed CEC topology computation firmware: Redo CEC code cleanup 4: Removed unused functions firmware: Redo CEC code cleanup 5: Removed Rx processing firmware: Redo CEC code cleanup 6: Logging changed to VCOS firmware: Redo CEC code cleanup 7: Removed hdmi_state_machine_clock_changed firmware: Redo CEC code cleanup 8: fixed hdmi state machine clk firmware: Redo CEC code cleanup 10: misc cosmetic changes firmware: Fixup CEC code cleanup 8: fixed hdmi state machine clk firmware: hdmi: Add way of forcing logging for hdmi and cec from boot firmware: Redo CEC code cleanup 11: cec_release_logical_addr firmware: arm_loader: Respect smsc95xx.macaddr parameter See: raspberrypi/linux#1865 firmware: vec: Fix progressive scan composite mode See: #683 firmware: vec: PAL_M mode is 525/60 See: #756 firmware: IL ISP: Support Bayer firmware: IL ISP: Fix error in stride calcs for YUYV formats firmware: video_render: buffer size fixup for ARGB888 firmware: video_render: Support per-pixel alpha on RGBA input See: waveform80/picamera#199
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Mar 1, 2017
kernel: BCM2835-V4L2: Correctly denote key frames in encoded data kernel: bcm2835-gpio-exp: Driver for GPIO expander via mailbox service See: raspberrypi/linux#1852 kernel: Add overlay for ads1115 ADCs See: raspberrypi/linux#1864 kernel: Add support for Fe-Pi audio sound card See: raspberrypi/linux#1867 kernel: amba_pl011: Round input clock up kernel: clk-bcm2835: Correct the prediv logic firmware: Redo CEC code cleanup 3: Removed CEC topology computation firmware: Redo CEC code cleanup 4: Removed unused functions firmware: Redo CEC code cleanup 5: Removed Rx processing firmware: Redo CEC code cleanup 6: Logging changed to VCOS firmware: Redo CEC code cleanup 7: Removed hdmi_state_machine_clock_changed firmware: Redo CEC code cleanup 8: fixed hdmi state machine clk firmware: Redo CEC code cleanup 10: misc cosmetic changes firmware: Fixup CEC code cleanup 8: fixed hdmi state machine clk firmware: hdmi: Add way of forcing logging for hdmi and cec from boot firmware: Redo CEC code cleanup 11: cec_release_logical_addr firmware: arm_loader: Respect smsc95xx.macaddr parameter See: raspberrypi/linux#1865 firmware: vec: Fix progressive scan composite mode See: raspberrypi/firmware#683 firmware: vec: PAL_M mode is 525/60 See: raspberrypi/firmware#756 firmware: IL ISP: Support Bayer firmware: IL ISP: Fix error in stride calcs for YUYV formats firmware: video_render: buffer size fixup for ARGB888 firmware: video_render: Support per-pixel alpha on RGBA input See: waveform80/picamera#199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st patch is a slightly bizarre one.
The timestamp on any inline header bytes of an H264 stream comes back as 0. This patch now gives them the same timestamp as the previous frame to the header bytes.
On the VPU the header bytes are detached from any "job", and only the job has a timestamp. It might be possible to work around that and provide timestamps from the VPU, but it's an interesting question as to what the appropriate timestamp should be.
2nd is tagging keyframes correctly at the V4L2 level. The MMAL buffers already had the flags set.
3rd is as reviewed by Phil already to add a new driver to control the FXL6408 GPIO expander via the mailbox service. Supports state and direction control, and has plumbed through the power LED via DT.