Skip to content

BCM270X_DT: Invert Pi3 power LED to match fw change #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2017

Conversation

6by9
Copy link
Contributor

@6by9 6by9 commented Mar 7, 2017

Firmware expgpio driver reworked due to complaint over
hotplug detect.
Requires power LED to change sense as firmware is no longer
inverting the read value.

Signed-off-by: Dave Stevenson [email protected]

Firmware expgpio driver reworked due to complaint over
hotplug detect.
Requires power LED to change sense as firmware is no longer
inverting the read value.

Signed-off-by: Dave Stevenson <[email protected]>
@6by9
Copy link
Contributor Author

6by9 commented Mar 7, 2017

@pelwell if gpio expander is reading the raw value for #1869, then the power LED has the wrong sense.
Switch to not inverting.
This requires the associated firmware change.

@pelwell
Copy link
Contributor

pelwell commented Mar 7, 2017

Looks OK to me.

The sense of the LED only makes a difference to an output. Since the standard trigger is "input", getting
out-of-sync with the firmware will only affect those people who override the trigger.

@popcornmix popcornmix merged commit a599f69 into raspberrypi:rpi-4.9.y Mar 13, 2017
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Mar 13, 2017
kernel: BCM270X_DT: Invert Pi3 power LED to match fw change
See: raspberrypi/linux#1879

kernel: Add support for the AudioInjector Octo sound card
See: raspberrypi/linux#1884

kernel: Fix gadget mode for bcm2835
See: raspberrypi/linux#1887

kernel: bcm2835-v4l2: Fix buffer overflow problem
See: raspberrypi/linux#1890

kernel: Add support for Fe-Pi audio sound card
See: raspberrypi/linux#1867

kernel: BCM270X_DT: Flip the polarity of the CM3's HDMI HPD
See: raspberrypi/linux#1869

kernel: Add overlay for ads1115 ADCs
See: raspberrypi/linux#1864

kernel: config: Add CONFIG_CRYPTO_LZ4
See: raspberrypi/linux#1875

kernel: clk-bcm2835: Read max core clock from firmware

firmware: GPIO expander: rework so the mailbox service reads raw values
firmware: arm_loader: Check GPIO direction for low_voltage
See: raspberrypi/linux#1879

firmware: warnings: Fix some mostly spurious warnings

firmware: clock: Calculate PLL multipliers with more precision
firmware: Set up HDMI VCO same for VEC as for HDMI

firmeare: gpu_server: Move detailed logging to LOGGING_VMCS_VERBOSE category
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Mar 13, 2017
kernel: BCM270X_DT: Invert Pi3 power LED to match fw change
See: raspberrypi/linux#1879

kernel: Add support for the AudioInjector Octo sound card
See: raspberrypi/linux#1884

kernel: Fix gadget mode for bcm2835
See: raspberrypi/linux#1887

kernel: bcm2835-v4l2: Fix buffer overflow problem
See: raspberrypi/linux#1890

kernel: Add support for Fe-Pi audio sound card
See: raspberrypi/linux#1867

kernel: BCM270X_DT: Flip the polarity of the CM3's HDMI HPD
See: raspberrypi/linux#1869

kernel: Add overlay for ads1115 ADCs
See: raspberrypi/linux#1864

kernel: config: Add CONFIG_CRYPTO_LZ4
See: raspberrypi/linux#1875

kernel: clk-bcm2835: Read max core clock from firmware

firmware: GPIO expander: rework so the mailbox service reads raw values
firmware: arm_loader: Check GPIO direction for low_voltage
See: raspberrypi/linux#1879

firmware: warnings: Fix some mostly spurious warnings

firmware: clock: Calculate PLL multipliers with more precision
firmware: Set up HDMI VCO same for VEC as for HDMI

firmeare: gpu_server: Move detailed logging to LOGGING_VMCS_VERBOSE category
@pelwell
Copy link
Contributor

pelwell commented Mar 14, 2017

This is now in the latest rpi-update firmware release.

mkreisl added a commit to xbianonpi/xbian-package-firmware that referenced this pull request Mar 26, 2017
- firmware: dtoverlay: find symbols, write properties
  See: #613

- firmware: arm_loader: Clean up cmdline, add local-mac-address to DT
  See: #613

- firmware: gpuserv: Boost gpu frequencies when in use

- firmware: ILCamera: Add option to disable ISP processing stages

- firmware: MMAL/IL: Allow video render to take non aligned sliceheight
- firmware: IL ISP: Support unaligned nSliceHeight on input
- firmware: Redo CEC code cleanup 3: Removed CEC topology computation
- firmware: Redo CEC code cleanup 4: Removed unused functions
- firmware: Redo CEC code cleanup 5: Removed Rx processing
- firmware: Redo CEC code cleanup 6: Logging changed to VCOS
- firmware: Redo CEC code cleanup 7: Removed hdmi_state_machine_clock_changed
- firmware: Redo CEC code cleanup 8: fixed hdmi state machine clk
- firmware: Redo CEC code cleanup 10: misc cosmetic changes
- firmware: Fixup CEC code cleanup 8: fixed hdmi state machine clk
- firmware: hdmi: Add way of forcing logging for hdmi and cec from boot
- firmware: Redo CEC code cleanup 11: cec_release_logical_addr

- firmware: arm_loader: Respect smsc95xx.macaddr parameter
  See: raspberrypi/linux#1865

- firmware: vec: Fix progressive scan composite mode
  See: #683

- firmware: vec: PAL_M mode is 525/60
  See: #756

- firmware: IL ISP: Support Bayer
- firmware: IL ISP: Fix error in stride calcs for YUYV formats
- firmware: video_render: buffer size fixup for ARGB888

- firmware: video_render: Support per-pixel alpha on RGBA input
  See: waveform80/picamera#199

- firmware: cmake: Expose all symbols from vchostif in bcm_host

- firmware: vec: first field odd should be related to vertical resolution

- firmware: vec: Avoid rolling display with progressive PAL
  See: #683

- firmware: platform: Treat Pi0W like Pi0 w.r.t. clocks and voltages

- firmware: platform: Add final Pi Zero W support

- firmware: GPIO expander: rework so the mailbox service reads raw values
- firmware: arm_loader: Check GPIO direction for low_voltage
  See: raspberrypi/linux#1879

- firmware: warnings: Fix some mostly spurious warnings

- firmware: clock: Calculate PLL multipliers with more precision
- firmware: Set up HDMI VCO same for VEC as for HDMI

- firmeware: gpu_server: Move detailed logging to LOGGING_VMCS_VERBOSE category

- firmware: FXL6408: Remove assert of output state of an input being set

- firmware: ISP tuner/3D: Stop AWB using V3D if disabled from VPU

- firmware: cmake: Install user-vcsm.h to opt/vc/include/interface/vcsm

- firmware: dtoverlay: Make empty alias a valid string
- firmware: dtoverlay: Add dt_node_is_enabled
- firmware: arm_loader: Create simplefb if no /soc/fb
  See: #763

- firmware: isp: Request turbo mode for isp when active
- firmware: isp: Avoid reducing isp clock frequency when initialising

- firmware: gpu_server: unreserve the qpu user shaders at end of each job
- firmware: gpu_server: Only enable/disable qpus at start/end of service connection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants