dwc_otg: Fixes for root port disconnect issues #2010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 12, 2017 12:47
On root port disconnect events, the host driver state is cleared and in-progress host channels are forcibly stopped. This doesn't play well with the FIQ running in the background, so: - Guard the disconnect callback with both the host spinlock and FIQ spinlock - Move qtd dereference in dwc_otg_handle_hc_fsm() after the early-out so we don't dereference a qtd that has gone away - Turn catch-all BUG()s in dwc_otg_handle_hc_fsm() into warnings.
The lock serves no purpose as it is only held while the HCD spinlock is already being held.
…rrupt Host channels are already halted in kill_urbs_in_qh_list() with the subsequent interrupt processing behaving as if the URB was dequeued via HCD callback. There's no need to clobber the host channel registers a second time as this exposes races between the driver and host channel resulting in hcd->free_hc_list becoming corrupted.
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 15, 2017
kernel: dwc_otg: Fixes for root port disconnect issues See: raspberrypi/linux#2010 kernel: BCM270X_DT: Tidy up mmc, sdhost, sdio overlays See: raspberrypi/linux#2003 firmware: platform: Move trait initialisation out of #ifdef'd function firmware: usb: Change USB PHY settings to make device mode work correctly firmware: dtoverlay: Update fixups when a node is renamed firmware: dtoverlay app: Add the -D (dry-run) option See: raspberrypi/linux#2002 firmware: dispserver: Adjust open/close refcount on application exit See: #778 firmware: filex: Optimise directory search of the root directory
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
May 15, 2017
kernel: dwc_otg: Fixes for root port disconnect issues See: raspberrypi/linux#2010 kernel: BCM270X_DT: Tidy up mmc, sdhost, sdio overlays See: raspberrypi/linux#2003 firmware: platform: Move trait initialisation out of #ifdef'd function firmware: usb: Change USB PHY settings to make device mode work correctly firmware: dtoverlay: Update fixups when a node is renamed firmware: dtoverlay app: Add the -D (dry-run) option See: raspberrypi/linux#2002 firmware: dispserver: Adjust open/close refcount on application exit See: raspberrypi/firmware#778 firmware: filex: Optimise directory search of the root directory
This was referenced May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1272.
Repeatedly toggling buspower now no longer crashes the Pi for me with these fixes applied.