mpu6050 device tree overlay #2031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelwell
approved these changes
May 23, 2017
arch/arm/boot/dts/overlays/Makefile
Outdated
| @@ -109,7 +109,8 @@ dtbo-$(CONFIG_ARCH_BCM2835) += \ | |||
| vga666.dtbo \ | |||
| w1-gpio.dtbo \ | |||
| w1-gpio-pullup.dtbo \ | |||
| wittypi.dtbo | |||
| wittypi.dtbo \ | |||
| mpu6050.dtbo | |||
There was a problem hiding this comment.
All the other entries are in strict alphabetical order - please do the same. As well as being tidy and logical it helps to avoid merge conflicts.
| compatible = "invensense,mpu6050"; | ||
| reg = <0x68>; | ||
| interrupt-parent = <&gpio>; | ||
| interrupts = <4 1>; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| __overrides__ { | ||
| mpu6050_interrupt_pin = <&mpu6050>,"interrupts:0"; |
There was a problem hiding this comment.
You don't need to qualify the parameter name with the device name - the parameters exposed by an overlay are only in scope until the next overlay is loaded, so it is safe to have multiple overlays all using the same parameter names. Other overlays have used interrupt or int_pin.
| status = "okay"; | ||
| clock-frequency = <400000>; | ||
|
|
||
| inv-mpu6050@68 { |
There was a problem hiding this comment.
I don't think the inv- prefix adds anything - the dtbindings documentation just uses mpu6050@68.
arch/arm/configs/bcm2709_defconfig
Outdated
| @@ -1171,6 +1171,8 @@ CONFIG_IIO=m | |||
| CONFIG_IIO_BUFFER=y | |||
| CONFIG_IIO_BUFFER_CB=m | |||
| CONFIG_IIO_KFIFO_BUF=m | |||
| CONFIG_INV_MPU6050_IIO=m | |||
There was a problem hiding this comment.
This isn't what savedefconfig generates - I get:
index 9164668..575cf99 100644
--- a/arch/arm/configs/bcm2709_defconfig
+++ b/arch/arm/configs/bcm2709_defconfig
@@ -1171,15 +1171,12 @@ CONFIG_RASPBERRYPI_POWER=y
CONFIG_EXTCON=m
CONFIG_EXTCON_ARIZONA=m
CONFIG_IIO=m
-CONFIG_IIO_BUFFER=y
CONFIG_IIO_BUFFER_CB=m
-CONFIG_IIO_KFIFO_BUF=m
-CONFIG_INV_MPU6050_IIO=m
-CONFIG_INV_MPU6050_I2C=m
CONFIG_MCP320X=m
CONFIG_MCP3422=m
CONFIG_DHT11=m
CONFIG_HTU21=m
+CONFIG_INV_MPU6050_I2C=m
CONFIG_BMP280=m
CONFIG_PWM_BCM2835=m
Setting INV_MPU6050_I2C is enough to imply INV_MPU6050_IIO, IIO_BUFFER and IIO_KFIFO_BUF. The order in the Kconfig files determines where they should go.
Using make ARCH=arm savedefconfig minimises the number of changes, and prevents others encountering spurious differences when they subsequently use the same mechanism themselves.
pelwell
requested changes
May 23, 2017
|
Add fixes according to your comments |
|
Somehow I think you missed out bcmrpi_defconfig in your commits. If you could also change the node name from |
pelwell
approved these changes
May 23, 2017
|
Merged. FYI you can also put parameters on the same line, e.g. |
popcornmix
pushed a commit
that referenced
this pull request
May 24, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 26, 2017
kernel: dwc_otg: make periodic scheduling behave properly for FS buses See: raspberrypi/linux#2020 kernel: HID: usbhid: extend polling interval configuration to joysticks See: raspberrypi/linux#2036 kernel: clk: bcm2835: Minimise clock jitter for PCM clock See: raspberrypi/linux#2016 kernel: Add mpu6050 device tree overlay See: raspberrypi/linux#2031 kernel: config: Add CONFIG_IPV6_SIT_6RD See: raspberrypi/linux#1598 kernel: config: Add CONFIG_IPV6_ROUTE_INFO See: raspberrypi/linux#1957
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
May 26, 2017
kernel: dwc_otg: make periodic scheduling behave properly for FS buses See: raspberrypi/linux#2020 kernel: HID: usbhid: extend polling interval configuration to joysticks See: raspberrypi/linux#2036 kernel: clk: bcm2835: Minimise clock jitter for PCM clock See: raspberrypi/linux#2016 kernel: Add mpu6050 device tree overlay See: raspberrypi/linux#2031 kernel: config: Add CONFIG_IPV6_SIT_6RD See: raspberrypi/linux#1598 kernel: config: Add CONFIG_IPV6_ROUTE_INFO See: raspberrypi/linux#1957
pelwell
pushed a commit
that referenced
this pull request
Jul 10, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
pelwell
pushed a commit
that referenced
this pull request
Jul 10, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Jul 12, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Jul 13, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Jul 13, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Jul 16, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Jul 16, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Jul 17, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Jul 21, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Jul 21, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Jul 27, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Jul 29, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Aug 1, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Aug 8, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Aug 8, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Aug 10, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Aug 13, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Aug 13, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Aug 14, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Aug 23, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Aug 23, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Aug 25, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Aug 30, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Sep 1, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Sep 4, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Sep 8, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Sep 13, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Sep 13, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Sep 14, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Sep 14, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Sep 22, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
popcornmix
pushed a commit
that referenced
this pull request
Oct 29, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
ryncsn
pushed a commit
to ryncsn/linux-rasp
that referenced
this pull request
Nov 21, 2017
Add overlay and config options for InvenSense MPU6050 6-axis motion detector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to write in
/boot/config.txtdtoverlay=mpu6050and use mpu6050 connected on i2c interface from userspace
Also add ability to choose interrupt pin with
dtparam=mpu6050_interrupt_pin=<gpio_num>