net: lan78xx: fix rx handling before first packet is send #2620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As long the bh tasklet isn't scheduled once, no packet from the rx path will be handled. Since the tx path also schedule the same tasklet this situation only persits until the first packet transmission. So fix this issue by scheduling the tasklet during ndo_open like in usbnet. Link: raspberrypi#2617 Fixes: 55d7de9 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet") Suggested-by: Floris Bos <[email protected]> Signed-off-by: Stefan Wahren <[email protected]>
|
LGTM |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jul 18, 2018
kernel: vc4 unbalanced irq fix See: raspberrypi/linux#2618 kernel: net: lan78xx: fix rx handling before first packet is send kernel: lan78xx: Fix link status notifications See: raspberrypi/linux#2620 firmware: isp: IL compatibility and alignment tweaks firmware: IL ISP: Use vc_image instead of reworking own stride checking firmware: isp: Minor clean ups firmware: dispmanx: Complete the format strings for dispmanx_parse_list firmware: IL ISP: Use vc_image instead of reworking own stride checking firmware: MMAL/IL: Add support for components to report alignment requirements
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Jul 18, 2018
kernel: vc4 unbalanced irq fix See: raspberrypi/linux#2618 kernel: net: lan78xx: fix rx handling before first packet is send kernel: lan78xx: Fix link status notifications See: raspberrypi/linux#2620 firmware: isp: IL compatibility and alignment tweaks firmware: IL ISP: Use vc_image instead of reworking own stride checking firmware: isp: Minor clean ups firmware: dispmanx: Complete the format strings for dispmanx_parse_list firmware: IL ISP: Use vc_image instead of reworking own stride checking firmware: MMAL/IL: Add support for components to report alignment requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long the bh tasklet isn't scheduled once, no packet from the rx path
will be handled. Since the tx path also schedule the same tasklet
this situation only persits until the first packet transmission.
So fix this issue by scheduling the tasklet during ndo_open like in usbnet.
#2617