Vchiq cache #2666
Vchiq cache #2666
Conversation
…ty (v3)"" This reverts commit 6823be4.
The ARM coprocessor registers include dcache line size, but there is no function to expose this value. Rather than create a new one, use the read_cpuid_id function to derive the correct value, which is 32 for BCM2835 and 64 for BCM2836/7. Signed-off-by: Phil Elwell <[email protected]>
The size field in a Device Tree "reg" property is encoded in bytes, not words. Signed-off-by: Phil Elwell <[email protected]>
|
A preview firmware release that implements the new logic can be downloaded here: https://drive.google.com/file/d/13c66cJkNmCQFMd7_f3GNA_tk5usoK0ZW/view?usp=sharing |
|
Thanks a lot! Testing on RPi3B+ with the preview firmware worked fine - tvservice -m showed correct lists of modes. When using the current official firmware I got a corrupted mode list with this PR - but I guess this is to be expected? |
|
Yes it is. The current firmware assumes that a lack of |
Retain a vestigial cache_line_size parameter to improve backwards- compatibility. Signed-off-by: Phil Elwell <[email protected]>
|
The DT commit has been updated to retain a vestigial |
|
thanks, the updated version works fine with the August 24 firmware |
|
Confirmed, 4.18.5 works with older firmware (Jul 23) |
This series of commits gives the vchiq driver the ability to discern the
correct cache_line_size value in the absence of the cache-line-size
property. The correction of the reg size value doubles as a hint to
the firmware that the kernel includes the updated value.
See: #2643
Signed-off-by: Phil Elwell [email protected]