Skip to content

lan78xx: use default alignment for rx buffers #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2019

Conversation

P33M
Copy link
Contributor

@P33M P33M commented May 2, 2019

The lan78xx uses a 12-byte hardware rx header, so there is no need
to allocate SKBs with NET_IP_ALIGN set. Removes alignment faults
in both dwc_otg and in ipv6 processing.

The lan78xx uses a 12-byte hardware rx header, so there is no need
to allocate SKBs with NET_IP_ALIGN set. Removes alignment faults
in both dwc_otg and in ipv6 processing.
@pelwell pelwell merged commit 2f5a6b9 into raspberrypi:rpi-4.19.y May 2, 2019
@P33M
Copy link
Contributor Author

P33M commented May 2, 2019

@JamesH65 just pointed me at #2599
Where a patch apparently went upstream replicating the change made here. This change can be dropped if and when the upstream change filters through to us.

@pelwell
Copy link
Contributor

pelwell commented May 2, 2019

This is probably the patch going upstream: https://www.spinics.net/lists/netdev/msg545832.html
I notice it has no "Signed-off-by:" line, which usually means failure, and Patchwork says "Changes requested" even though I've not seen any real feedback to the patch. Don't hold your breath.

popcornmix added a commit to raspberrypi/firmware that referenced this pull request May 2, 2019
… bytes

See: raspberrypi/linux#2950

kernel: lan78xx: use default alignment for rx buffers
See: raspberrypi/linux#2953

kernel: configs: Enable netdev LED trigger
See: raspberrypi/linux#2951
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request May 2, 2019
… bytes

See: raspberrypi/linux#2950

kernel: lan78xx: use default alignment for rx buffers
See: raspberrypi/linux#2953

kernel: configs: Enable netdev LED trigger
See: raspberrypi/linux#2951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants