Skip to content

configs: arm64/bcm2711: Add MMC_SDHCI_IPROC #3045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

agherzan
Copy link
Contributor

@agherzan agherzan commented Jul 3, 2019

This driver is used in the device tree for the emmc2 node.

See #3032

This driver is used in the device tree for the emmc2 node.

See raspberrypi#3032

Signed-off-by: Andrei Gherzan <[email protected]>
@agherzan agherzan force-pushed the ag/rpi4-64-iproc branch from f53374e to 4a14d01 Compare July 3, 2019 12:54
agherzan added a commit to agherzan/meta-raspberrypi that referenced this pull request Jul 3, 2019
emmc dt node uses iproc sdhci driver. Make sure it is enabled.
raspberrypi/linux#3045

Signed-off-by: Andrei Gherzan <[email protected]>
@pelwell pelwell merged commit 395a6a8 into raspberrypi:rpi-4.19.y Jul 3, 2019
@pelwell
Copy link
Contributor

pelwell commented Jul 3, 2019

Thanks! This must have got lost somewhere along the way.

By the way, the next firmware release should include the ARMv8 + GIC stub.

@Strit
Copy link
Contributor

Strit commented Jul 3, 2019

Thanks! This must have got lost somewhere along the way.

By the way, the next firmware release should include the ARMv8 + GIC stub.

Awesome. Can't wait for it. Right now we are just hacking it in! 😃

@agherzan
Copy link
Contributor Author

agherzan commented Jul 3, 2019

Good stuff @pelwell

@agherzan
Copy link
Contributor Author

agherzan commented Jul 3, 2019

@Strit if you are using Yocto you will be having the "hack" built in soon. Just waiting on the builds.

artynet pushed a commit to artynet/rpi-linux that referenced this pull request Jul 4, 2019
Fix the cb_break_lock spinlock in afs_volume struct by initialising it when
the volume record is allocated.

Also rename the lock to cb_v_break_lock to distinguish it from the lock of
the same name in the afs_server struct.

Without this, the following trace may be observed when a volume-break
callback is received:

  INFO: trying to register non-static key.
  the code is fine but needs lockdep annotation.
  turning off the locking correctness validator.
  CPU: 2 PID: 50 Comm: kworker/2:1 Not tainted 5.2.0-rc1-fscache+ raspberrypi#3045
  Hardware name: ASUS All Series/H97-PLUS, BIOS 2306 10/09/2014
  Workqueue: afs SRXAFSCB_CallBack
  Call Trace:
   dump_stack+0x67/0x8e
   register_lock_class+0x23b/0x421
   ? check_usage_forwards+0x13c/0x13c
   __lock_acquire+0x89/0xf73
   lock_acquire+0x13b/0x166
   ? afs_break_callbacks+0x1b2/0x3dd
   _raw_write_lock+0x2c/0x36
   ? afs_break_callbacks+0x1b2/0x3dd
   afs_break_callbacks+0x1b2/0x3dd
   ? trace_event_raw_event_afs_server+0x61/0xac
   SRXAFSCB_CallBack+0x11f/0x16c
   process_one_work+0x2c5/0x4ee
   ? worker_thread+0x234/0x2ac
   worker_thread+0x1d8/0x2ac
   ? cancel_delayed_work_sync+0xf/0xf
   kthread+0x11f/0x127
   ? kthread_park+0x76/0x76
   ret_from_fork+0x24/0x30

Fixes: 68251f0 ("afs: Fix whole-volume callback handling")
Signed-off-by: David Howells <[email protected]>
agherzan added a commit to agherzan/meta-raspberrypi that referenced this pull request Jul 4, 2019
emmc dt node uses iproc sdhci driver. Make sure it is enabled.
raspberrypi/linux#3045

Signed-off-by: Andrei Gherzan <[email protected]>
agherzan added a commit to agherzan/meta-raspberrypi that referenced this pull request Jul 18, 2019
emmc dt node uses iproc sdhci driver. Make sure it is enabled.
raspberrypi/linux#3045

Signed-off-by: Andrei Gherzan <[email protected]>
agherzan added a commit to agherzan/meta-raspberrypi that referenced this pull request Jul 20, 2019
emmc dt node uses iproc sdhci driver. Make sure it is enabled.
raspberrypi/linux#3045

Signed-off-by: Andrei Gherzan <[email protected]>
popcornmix pushed a commit that referenced this pull request Jul 25, 2019
[ Upstream commit 90fa9b6 ]

Fix the cb_break_lock spinlock in afs_volume struct by initialising it when
the volume record is allocated.

Also rename the lock to cb_v_break_lock to distinguish it from the lock of
the same name in the afs_server struct.

Without this, the following trace may be observed when a volume-break
callback is received:

  INFO: trying to register non-static key.
  the code is fine but needs lockdep annotation.
  turning off the locking correctness validator.
  CPU: 2 PID: 50 Comm: kworker/2:1 Not tainted 5.2.0-rc1-fscache+ #3045
  Hardware name: ASUS All Series/H97-PLUS, BIOS 2306 10/09/2014
  Workqueue: afs SRXAFSCB_CallBack
  Call Trace:
   dump_stack+0x67/0x8e
   register_lock_class+0x23b/0x421
   ? check_usage_forwards+0x13c/0x13c
   __lock_acquire+0x89/0xf73
   lock_acquire+0x13b/0x166
   ? afs_break_callbacks+0x1b2/0x3dd
   _raw_write_lock+0x2c/0x36
   ? afs_break_callbacks+0x1b2/0x3dd
   afs_break_callbacks+0x1b2/0x3dd
   ? trace_event_raw_event_afs_server+0x61/0xac
   SRXAFSCB_CallBack+0x11f/0x16c
   process_one_work+0x2c5/0x4ee
   ? worker_thread+0x234/0x2ac
   worker_thread+0x1d8/0x2ac
   ? cancel_delayed_work_sync+0xf/0xf
   kthread+0x11f/0x127
   ? kthread_park+0x76/0x76
   ret_from_fork+0x24/0x30

Fixes: 68251f0 ("afs: Fix whole-volume callback handling")
Signed-off-by: David Howells <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
popcornmix pushed a commit that referenced this pull request Jul 25, 2019
[ Upstream commit 90fa9b6 ]

Fix the cb_break_lock spinlock in afs_volume struct by initialising it when
the volume record is allocated.

Also rename the lock to cb_v_break_lock to distinguish it from the lock of
the same name in the afs_server struct.

Without this, the following trace may be observed when a volume-break
callback is received:

  INFO: trying to register non-static key.
  the code is fine but needs lockdep annotation.
  turning off the locking correctness validator.
  CPU: 2 PID: 50 Comm: kworker/2:1 Not tainted 5.2.0-rc1-fscache+ #3045
  Hardware name: ASUS All Series/H97-PLUS, BIOS 2306 10/09/2014
  Workqueue: afs SRXAFSCB_CallBack
  Call Trace:
   dump_stack+0x67/0x8e
   register_lock_class+0x23b/0x421
   ? check_usage_forwards+0x13c/0x13c
   __lock_acquire+0x89/0xf73
   lock_acquire+0x13b/0x166
   ? afs_break_callbacks+0x1b2/0x3dd
   _raw_write_lock+0x2c/0x36
   ? afs_break_callbacks+0x1b2/0x3dd
   afs_break_callbacks+0x1b2/0x3dd
   ? trace_event_raw_event_afs_server+0x61/0xac
   SRXAFSCB_CallBack+0x11f/0x16c
   process_one_work+0x2c5/0x4ee
   ? worker_thread+0x234/0x2ac
   worker_thread+0x1d8/0x2ac
   ? cancel_delayed_work_sync+0xf/0xf
   kthread+0x11f/0x127
   ? kthread_park+0x76/0x76
   ret_from_fork+0x24/0x30

Fixes: 68251f0 ("afs: Fix whole-volume callback handling")
Signed-off-by: David Howells <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
daregit pushed a commit to daregit/yocto-combined that referenced this pull request May 22, 2024
emmc dt node uses iproc sdhci driver. Make sure it is enabled.
raspberrypi/linux#3045

Signed-off-by: Andrei Gherzan <[email protected]>
daregit pushed a commit to daregit/yocto-combined that referenced this pull request May 22, 2024
emmc dt node uses iproc sdhci driver. Make sure it is enabled.
raspberrypi/linux#3045

Signed-off-by: Andrei Gherzan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants