Skip to content

Correct the name of the Raspberry Pi video decoder #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2019

Conversation

pelwell
Copy link
Contributor

@pelwell pelwell commented Jul 29, 2019

Give a the Raspberry Pi-developed video decoder block in BCM2711
a more self-explanatory name.

Phil Elwell added 2 commits July 29, 2019 12:33
Replace the old code name with a more appropriate name - RPiVid.

Signed-off-by: Phil Elwell <[email protected]>
Provide transitional support for the previous names of
the character devices.

Signed-off-by: Phil Elwell <[email protected]>
@pelwell pelwell requested a review from P33M July 29, 2019 11:36
@JamesH65
Copy link
Contributor

Should the commit also mention the device minor node change? It appears to be the one functional change that might have an impact elsewhere.

@pelwell
Copy link
Contributor Author

pelwell commented Jul 29, 2019

You mean that the old name is now temporarily assigned to a new minor number, prior to removal? I'd be very surprised if any code outside the kernel knows or cares about the device numbers, major or minor.

@P33M
Copy link
Contributor

P33M commented Jul 29, 2019

The existing ffmpeg "decoder" .so references the device nodes by name, so as long as there's a legacy name match it should still work. I'm unaware of any other software making use of this interface at this time.

ping @popcornmix - any other decoders that we know of?

@pelwell
Copy link
Contributor Author

pelwell commented Jul 29, 2019

LibreELEC/OpenELEC uses the names: CoreELEC/CoreELEC@84e70210df

@popcornmix
Copy link
Collaborator

I imagine everything will use names rather than numbers (it will all be based on the ffmpeg code).

VLC will need updating to new names but that hasn't been released so we just need to ping John.

@popcornmix
Copy link
Collaborator

Note: LibreELEC will need to update their kernel config (they don't use ours).

@popcornmix
Copy link
Collaborator

Note: the raspbian udev rule

SUBSYSTEM=="argon-*", GROUP="video", MODE="0660"

doesn't work with this update.

pi@pi4:~ $ ls -l /dev/argon-*
crw------- 1 root root 239, 1 Jul 30 14:02 /dev/argon-h264mem
crw------- 1 root root 241, 1 Jul 30 14:02 /dev/argon-hevcmem
crw------- 1 root root 240, 1 Jul 30 14:02 /dev/argon-intcmem
crw------- 1 root root 238, 1 Jul 30 14:02 /dev/argon-vp9mem

Editing it to rpivid-* does work (and changes both rpivid and the argon aliases).

Perhaps we want to update raspbian to include (ping @XECDesign):

SUBSYSTEM=="argon-*", GROUP="video", MODE="0660"
SUBSYSTEM=="rpivid-*", GROUP="video", MODE="0660"

before it upates the kernel.

Also - Arch will need a similar update (kodi packages for Arch have recently been made that include udev rules)

@XECDesign
Copy link
Contributor

Updated udev rule should show up in the repo shortly

@popcornmix popcornmix merged commit 75f1d14 into raspberrypi:rpi-4.19.y Aug 1, 2019
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Aug 1, 2019
kernel: Correct the name of the Raspberry Pi video decoder
See: raspberrypi/linux#3111

kernel: Fixup FKMS interrupt handing for non-existent display
See: raspberrypi/linux#3110

kernel: katana volume minimum value correction
See: raspberrypi/linux#3109

kernel: can: mcp251x: Allow more time after a reset
See: raspberrypi/linux#2767

kernel: overlays: Update the upstream overlay

kernel: overlays: Add audio parameter to vc4-kms-v3d
See: raspberrypi/linux#2489

firmware: pwm_audio: Use the correct DREQs on Pi4
See: #1214

firmware: pixelvalve_2711: Alter back porch for widths of 1366
See: #1202

firmware: Clear the SMIDSW1 display interrupt flag on startup

firmware: dt-blob: Declare Pi 4B's SD_IO voltage selector
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Aug 1, 2019
kernel: Correct the name of the Raspberry Pi video decoder
See: raspberrypi/linux#3111

kernel: Fixup FKMS interrupt handing for non-existent display
See: raspberrypi/linux#3110

kernel: katana volume minimum value correction
See: raspberrypi/linux#3109

kernel: can: mcp251x: Allow more time after a reset
See: raspberrypi/linux#2767

kernel: overlays: Update the upstream overlay

kernel: overlays: Add audio parameter to vc4-kms-v3d
See: raspberrypi/linux#2489

firmware: pwm_audio: Use the correct DREQs on Pi4
See: raspberrypi/firmware#1214

firmware: pixelvalve_2711: Alter back porch for widths of 1366
See: raspberrypi/firmware#1202

firmware: Clear the SMIDSW1 display interrupt flag on startup

firmware: dt-blob: Declare Pi 4B's SD_IO voltage selector
@pelwell pelwell deleted the rpivid branch September 15, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants