media: bcm2835-unicam: Retain packing information on G_FMT #3622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change to retrieve the pixel format always on g_fmt didn't check whether the native or unpacked version of the format had been requested, and always returned the packed one. Correct this so that the packing setting is retained whereever possible. Fixes "9d59e89 media: bcm2835-unicam: Re-fetch mbus code from subdev on a g_fmt call" Signed-off-by: Dave Stevenson <[email protected]>
|
LGTM. As we said for the offending commit, this really should be rolled into unicam_reset_format at some point. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 20, 2020
See: raspberrypi/linux#3626 kernel: VC4 DRM/KMS - use correct dma-ranges See: raspberrypi/linux#3623 kernel: media: bcm2835-unicam: Retain packing information on G_FMT See: raspberrypi/linux#3622 kernel: Switch to snd_soc_dai_set_bclk_ratio See: raspberrypi/linux#3620 kernel: V4L2 H264 framing fixes See: raspberrypi/linux#3614 kernel: drm/vc4: Fix VIC usage with Broadcast RGB See: raspberrypi/linux#3611 kernel: media: bcm2835-unicam: Always service interrupts See: raspberrypi/linux#3608 kernel: overlays: Fix audio parameter of vc4-kms-v3 See: raspberrypi/linux#2489 kernel: configs: Restore missing NF_TABLES settings See: raspberrypi/linux#3615 kernel: sc16is7xx: Fix for hardware flow control See: raspberrypi/linux#2542 kernel: Use the upstream cpufreq driver on non-BCM2835 Pis See: raspberrypi/linux#3604 kernel: Backport of udmabuf and dma-heaps See: raspberrypi/linux#3571 kernel: imx477 v4l2 driver See: raspberrypi/linux#3605 firmware: isp: fix ISP component to return non-zero focus FoMs firmware: Fix for IMX477 focal length, f_number and aperture firmware: Update firmware for USB MSD boot firmware: platform: Fix overflow on high arm overclocks firmware: video_encode: Add option to include header bytes with frame firmware: DSI display: Close I2C handle if the display doesn't probe firmware: mmal/vc: Add mapping for OMX_IndexConfigBufferStall / MMAL_PARAMETER_VIDEO_STALL_THRESHOLD See: https://www.raspberrypi.org/forums/viewtopic.php?f=70&t=273123&p=1655481 firmware: hdmi: Request an I2C interrupt for EDID reading firmware: i2c: Move using_interrupt flag into periph_setup
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
May 20, 2020
See: raspberrypi/linux#3626 kernel: VC4 DRM/KMS - use correct dma-ranges See: raspberrypi/linux#3623 kernel: media: bcm2835-unicam: Retain packing information on G_FMT See: raspberrypi/linux#3622 kernel: Switch to snd_soc_dai_set_bclk_ratio See: raspberrypi/linux#3620 kernel: V4L2 H264 framing fixes See: raspberrypi/linux#3614 kernel: drm/vc4: Fix VIC usage with Broadcast RGB See: raspberrypi/linux#3611 kernel: media: bcm2835-unicam: Always service interrupts See: raspberrypi/linux#3608 kernel: overlays: Fix audio parameter of vc4-kms-v3 See: raspberrypi/linux#2489 kernel: configs: Restore missing NF_TABLES settings See: raspberrypi/linux#3615 kernel: sc16is7xx: Fix for hardware flow control See: raspberrypi/linux#2542 kernel: Use the upstream cpufreq driver on non-BCM2835 Pis See: raspberrypi/linux#3604 kernel: Backport of udmabuf and dma-heaps See: raspberrypi/linux#3571 kernel: imx477 v4l2 driver See: raspberrypi/linux#3605 firmware: isp: fix ISP component to return non-zero focus FoMs firmware: Fix for IMX477 focal length, f_number and aperture firmware: Update firmware for USB MSD boot firmware: platform: Fix overflow on high arm overclocks firmware: video_encode: Add option to include header bytes with frame firmware: DSI display: Close I2C handle if the display doesn't probe firmware: mmal/vc: Add mapping for OMX_IndexConfigBufferStall / MMAL_PARAMETER_VIDEO_STALL_THRESHOLD See: https://www.raspberrypi.org/forums/viewtopic.php?f=70&t=273123&p=1655481 firmware: hdmi: Request an I2C interrupt for EDID reading firmware: i2c: Move using_interrupt flag into periph_setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to retrieve the pixel format always on g_fmt didn't
check whether the native or unpacked version of the format
had been requested, and always returned the packed one.
Correct this so that the packing setting is retained whereever
possible.
Fixes "9d59e89 media: bcm2835-unicam: Re-fetch mbus code from subdev
on a g_fmt call"
Signed-off-by: Dave Stevenson [email protected]