Add Micro Crystal RV-1805 to i2c-rtc overlays #3651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpfleming
commented
Jun 1, 2020
|
Apart from the node name discussed above, you'll need to document the new parameters in the README. |
While the RV-1805 is supported by the rtc-abx80x driver via auto-detection, in order for it to be initialized properly it must be explcitly selected. Signed-off-by: Kevin P. Fleming <[email protected]>
|
Thanks! |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jun 3, 2020
kernel: vc4: Set driver_name for card See: raspberrypi/linux#3656 kernel: configs: Add SND_SOC_MAX98357A=m See: https://www.raspberrypi.org/forums/viewtopic.php?f=107&t=275919 kernel: Add Micro Crystal RV-1805 to i2c-rtc overlays See: raspberrypi/linux#3651 kernel: media: bcm2835-isp: fix bytes per line calculations for some image formats See: raspberrypi/linux#3645 kernel: media: bcm2835-unicam: change minimum number of vb2_queue buffers to 1 See: raspberrypi/linux#3638 kernel: media: i2c: imx477: Return correct result on sensor id verification See: raspberrypi/linux#3630 kernel: Clean up the VCHIQ 2711 DMA support See: raspberrypi/linux#3629 kernel: overlays: i2c-rtc-gpio: Fix trickle-resistor-ohms param See: raspberrypi/linux#3642 kernel: Enable hwmon for thermal zones See: raspberrypi/linux#3307
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Jun 3, 2020
kernel: vc4: Set driver_name for card See: raspberrypi/linux#3656 kernel: configs: Add SND_SOC_MAX98357A=m See: https://www.raspberrypi.org/forums/viewtopic.php?f=107&t=275919 kernel: Add Micro Crystal RV-1805 to i2c-rtc overlays See: raspberrypi/linux#3651 kernel: media: bcm2835-isp: fix bytes per line calculations for some image formats See: raspberrypi/linux#3645 kernel: media: bcm2835-unicam: change minimum number of vb2_queue buffers to 1 See: raspberrypi/linux#3638 kernel: media: i2c: imx477: Return correct result on sensor id verification See: raspberrypi/linux#3630 kernel: Clean up the VCHIQ 2711 DMA support See: raspberrypi/linux#3629 kernel: overlays: i2c-rtc-gpio: Fix trickle-resistor-ohms param See: raspberrypi/linux#3642 kernel: Enable hwmon for thermal zones See: raspberrypi/linux#3307
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In discussions with one of the maintainers about the rtc-abx80x driver and support of the RV-1805 device, it was made clear that relying on the auto-detection behavior in the driver will result in this device being improperly initialized. The maintainer would actually prefer to remove the auto-detection logic completely, but it at least works properly for the Abracon-branded devices originally supported by the driver.
This patch adds an explicit rv1805 entry to the i2c-rtc overlays so that the user can specify it in config.txt. It has been produced (and tested) against the rpi-5.4.y branch but should apply cleanly to the other branches as well.
Note that there is an existing difference between these overlays: i2c-rtc-overlay has support for the pcf85363, but the i2c-rtc-gpio-overlay does not. This results in numbering differences between some of the fragments.