media: i2c: imx219: Selection compliance fixes

[jmondi]

To comply with the intended usage of the V4L2 selection target when
used to retrieve a sensor image properties, adjust the rectangles
returned by the imx219 driver.

The top/left crop coordinates of the TGT_CROP rectangle were set to
(0, 0) instead of (8, 8) which is the offset from the larger physical
pixel array rectangle. This was also a mismatch with the default values
crop rectangle value, so this is corrected. Found with v4l2-compliance.

While at it, add V4L2_SEL_TGT_CROP_BOUNDS support: CROP_DEFAULT and
CROP_BOUNDS have the same size as the non-active pixels are not readable
using the selection API. Found with v4l2-compliance.

Fixes: e6d4ef7 ("media: i2c: imx219: Implement get_selection")
Signed-off-by: Hans Verkuil [email protected]
[reword commit message, use macros for pixel offsets]
Signed-off-by: Jacopo Mondi [email protected]

[6by9]

Has this actually been merged upstream yet? I don't see it in https://git.linuxtv.org/media_tree.git/log/drivers/media/i2c/imx219.c

https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/ seems to have had a lot of discussion, but is there an actual conclusion?
And https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/ seems to be in limbo too.

The question is more whether we expect to see further updates to this rather than objecting to the content.

[jmondi]

Hi Dave,

Has this actually been merged upstream yet? I don't see it in https://git.linuxtv.org/media_tree.git/log/drivers/media/i2c/imx219.c

https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/ seems to have had a lot of discussion, but is there an actual conclusion?
And https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/ seems to be in limbo too.

I got a confirmation from Sakari that he's going to collect:
https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

The patch itself has merits unrelated to the discussion on the V4L2 targets definition (which didn't end up with any actual change)

The question is more whether we expect to see further updates to this rather than objecting to the content.

I'm fine postponing merging this pull request until upstream does not collect the imx219 patch.

[6by9]

If Sakari is going to pick this patch up as is, then I'm happy to merge it now.

If we ask @pelwell nicely he may cherry-pick it through to our 5.10 branch too.

[jmondi]

I -literally- just received this automatic message:

This is an automatic generated email to let you know that the following patch were queued:
Subject: media: i2c: imx219: Selection compliance fixes

The patch should now be in media master.
Let's see if @pelwell is going to be nice with us!

[pelwell]

Done.