drm/vc4: Set a default HSM rate #4547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the firmware doesn't setup the HSM rate (such as when booting without an HDMI cable plugged in), its rate is 0 and thus any register access results in a CPU stall, even though HSM is enabled. Let's enforce a minimum rate at boot to avoid this issue. Signed-off-by: Maxime Ripard <[email protected]>
|
Confirmed this fixed linked issue. Pi3 booted without hdmi connected. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Aug 25, 2021
See: raspberrypi/linux#4371 kernel: drm/vc4: Set a default HSM rate See: raspberrypi/linux#4547
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Aug 25, 2021
See: raspberrypi/linux#4371 kernel: drm/vc4: Set a default HSM rate See: raspberrypi/linux#4547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the firmware doesn't setup the HSM rate (such as when booting
without an HDMI cable plugged in), its rate is 0 and thus any register
access results in a CPU stall, even though HSM is enabled.
Let's enforce a minimum rate at boot to avoid this issue.
Fixes #4457