Skip to content

staging/bcm2835-camera: Add support for H264_MIN_QP, H264_MAX_QP, MPEG_VIDEO_FORCE_KEY_FRAME #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2021
Merged

staging/bcm2835-camera: Add support for H264_MIN_QP, H264_MAX_QP, MPEG_VIDEO_FORCE_KEY_FRAME #4647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73288c3
staging/bcm2835-camera: Add support for H264_MIN_QP, H264_MAX_QP
soyersoyer Oct 23, 2021
9918c25
staging/bcm2835-camera: Add support for MPEG_VIDEO_FORCE_KEY_FRAME
soyersoyer Oct 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* core driver device
*/

#define V4L2_CTRL_COUNT 29 /* number of v4l controls */
#define V4L2_CTRL_COUNT 32 /* number of v4l controls */

enum {
COMP_CAMERA = 0,
Expand Down
33 changes: 33 additions & 0 deletions drivers/staging/vc04_services/bcm2835-camera/controls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,6 +1270,39 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[V4L2_CTRL_COUNT] = {
.mmal_id = MMAL_PARAMETER_INTRAPERIOD,
.setter = ctrl_set_video_encode_param_output,
},
{
.id = V4L2_CID_MPEG_VIDEO_H264_MIN_QP,
.type = MMAL_CONTROL_TYPE_STD,
.min = 0,
.max = 51,
.def = 0,
.step = 1,
.imenu = NULL,
.mmal_id = MMAL_PARAMETER_VIDEO_ENCODE_MIN_QUANT,
.setter = ctrl_set_video_encode_param_output,
},
{
.id = V4L2_CID_MPEG_VIDEO_H264_MAX_QP,
.type = MMAL_CONTROL_TYPE_STD,
.min = 0,
.max = 51,
.def = 0,
.step = 1,
.imenu = NULL,
.mmal_id = MMAL_PARAMETER_VIDEO_ENCODE_MAX_QUANT,
.setter = ctrl_set_video_encode_param_output,
},
{
.id = V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME,
.type = MMAL_CONTROL_TYPE_STD,
.min = 0,
.max = 0,
.def = 0,
.step = 0,
.imenu = NULL,
.mmal_id = MMAL_PARAMETER_VIDEO_REQUEST_I_FRAME,
.setter = ctrl_set_video_encode_param_output,
},
};

int bm2835_mmal_set_all_camera_controls(struct bm2835_mmal_dev *dev)
Expand Down