overlays: Add fbtft overlay #4677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelwell
reviewed
Nov 7, 2021
There was a problem hiding this comment.
Overall this looks great. Would you consider adding support for the other SPI interfaces as well? The spi<m>-<n> parameters (where one must be chosen) are now quite common - see the mcp2515 overlay for an example.
I only mention the tiny grammatical issue in the README because the rest is flawless.
arch/arm/boot/dts/overlays/README
Outdated
| This overlay seeks to replace the functionality provided by fbtft_device | ||
| which is now gone from the kernel. | ||
|
|
||
| Most displays from fbtft_device has been ported over. |
arch/arm/boot/dts/overlays/README
Outdated
| Example: | ||
| dtoverlay=fbtft,ili9341,bgr,reset_pin=23,dc_pin=24,led_pin=18,rotate=270 | ||
|
|
||
| The following features of fbtft_device has not been ported over: |
There was a problem hiding this comment.
"features ... have not been"
arch/arm/boot/dts/overlays/README
Outdated
| dtoverlay=fbtft,ili9341,bgr,reset_pin=23,dc_pin=24,led_pin=18,rotate=270 | ||
|
|
||
| The following features of fbtft_device has not been ported over: | ||
| - it's not possible to change the SPI bus number (spi0 is used) |
There was a problem hiding this comment.
I'd like to make this statement false.
arch/arm/boot/dts/overlays/README
Outdated
| speed SPI bus speed in Hz (default 32000000) | ||
| cpha Shifted clock phase (CPHA) mode | ||
| cpol Inverse clock polarity (CPOL) mode | ||
| cs Chip Select {0, 1} (default 0) |
There was a problem hiding this comment.
I'd like to see this replaced by spi<m>-<n> parameters (although it's good to see a lookup table being used in the implementation).
Add an overlay that provides much of the functionality that fbtft_device did. Signed-off-by: Noralf Trønnes <[email protected]>
|
I've pushed a new version with the requested changes. I've tried to avoid all the dormant spidev fragements that mcp2515 has, seems to be working. |
|
Thanks! |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Nov 8, 2021
kernel: overlays: Add fbtft overlay See: raspberrypi/linux#4677
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Nov 8, 2021
kernel: overlays: Add fbtft overlay See: raspberrypi/linux#4677
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Nov 8, 2021
kernel: overlays: Add fbtft overlay See: raspberrypi/linux#4677 firmware: hello_fft: Update outdated link to V3D spec firmware: hello_fft: Remove unused function declaration See: #1645 See: raspberrypi/userland#710
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Nov 8, 2021
kernel: overlays: Add fbtft overlay See: raspberrypi/linux#4677 firmware: hello_fft: Update outdated link to V3D spec firmware: hello_fft: Remove unused function declaration See: raspberrypi/firmware#1645 See: raspberrypi/userland#710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an overlay that provides much of the functionality that fbtft_device did.
Follow up from #4659