DRM: Clean up handling of panel orientation #4862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelwell
reviewed
Feb 1, 2022
Current usage of drm_connector_set_panel_orientation is from a panel's get_modes call. However if the panel orientation property doesn't exist on the connector at this point, then drm_mode_object triggers WARNs as the connector is already registered. Add an orientation variable to struct drm_panel and initialise it from drm_panel_init. panel_bridge_attach can then create the property before the connector is registered. Signed-off-by: Dave Stevenson <[email protected]>
Panel orientation is now handled by the drm_panel and panel_bridge frameworks, so remove the custom handling. Signed-off-by: Dave Stevenson <[email protected]>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 2, 2022
kernel: Patching lan78xx for SOF_TIMESTAMPING_TX_SOFTWARE support See: raspberrypi/linux#4856 kernel: i2c: bcm2835: Make clock-stretch timeout configurable See: raspberrypi/linux#4855 kernel: drm/vc4: Add DRM 210101010 RGB formats for hvs5. See: raspberrypi/linux#4859 kernel: vc4-kms-dpi overlay updates See: raspberrypi/linux#4860 kernel: Add Support for the Geekworm MZP280 DPI Display See: raspberrypi/linux#4853 kernel: DRM: Clean up handling of panel orientation See: raspberrypi/linux#4862 kernel: Add support for the MAX30102 heart rate and blood oxygen sensor See: raspberrypi/linux#4535 firmware: mmal: Add mapping for IL OMX_IndexParamBrcmEnableIJGTableScaling param See: raspberrypi/linux#4669 userland: Handle overlay parameters embedded in overlay_map.dtb See: raspberrypi/linux#4860
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Feb 2, 2022
kernel: Patching lan78xx for SOF_TIMESTAMPING_TX_SOFTWARE support See: raspberrypi/linux#4856 kernel: i2c: bcm2835: Make clock-stretch timeout configurable See: raspberrypi/linux#4855 kernel: drm/vc4: Add DRM 210101010 RGB formats for hvs5. See: raspberrypi/linux#4859 kernel: vc4-kms-dpi overlay updates See: raspberrypi/linux#4860 kernel: Add Support for the Geekworm MZP280 DPI Display See: raspberrypi/linux#4853 kernel: DRM: Clean up handling of panel orientation See: raspberrypi/linux#4862 kernel: Add support for the MAX30102 heart rate and blood oxygen sensor See: raspberrypi/linux#4535 firmware: mmal: Add mapping for IL OMX_IndexParamBrcmEnableIJGTableScaling param See: raspberrypi/linux#4669 userland: Handle overlay parameters embedded in overlay_map.dtb See: raspberrypi/linux#4860
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mripard to review please.
Noted on #4853