-
Notifications
You must be signed in to change notification settings - Fork 5.2k
overlays:fixes probing of Hifiberry DAC2 HD #4904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Does fragment 0 achieve anything? What happens if you delete it? |
Removed clocks-declarations in I2C sections of the DT-overlay which kept the devices from probing. Signed-off-by: Joerg Schambacher <[email protected]>
Yes, you're right with your assumption. That part is not necessary. |
kernel: overlays:fixes probing of Hifiberry DAC2 HD See: raspberrypi/linux#4904 kernel: overlays: Add overlays for WaveShare 2-Channel Isolated CAN FD HAT See: raspberrypi/linux#4907 kernel: configs: Add CONFIG_TINYDRM_HX8357D=m kernel: overlays: Add drm parameter to pitft35-resistive See: https://forums.raspberrypi.com/viewtopic.php?t=330088 kernel: ARM: dts: Add GPIO line names for downstream RPis See: raspberrypi/linux#2760 firmware: board_info: Handle misprogrammed 3B rev 1.2s firmware: mmal: Add mapping for IL OMX_IndexParamBrcmEnableIJGTableScaling param firmware: Handle overlay parameters embedded in overlay_map.dtb See: raspberrypi/linux#4860 firmware: firmware: Add HDMI_PORTS trait firmware: arm_dt: Fix rpi-poe overlay parameters See: #1689 firmware: jpeghw: Skip APP0 AVI1 headers, regardless of length See: https://forums.raspberrypi.com/viewtopic.php?p=1975448 firmware: camera_subsystem: Report ignored interfaces due to libcamera See: #1679 firmware: Export os_prefix, overlay_prefix, rsts and boot-mode on all models firmware: vcfw/hdmi_i2c: Initialise all instances from hdmi_i2c_init
kernel: overlays:fixes probing of Hifiberry DAC2 HD See: raspberrypi/linux#4904 kernel: overlays: Add overlays for WaveShare 2-Channel Isolated CAN FD HAT See: raspberrypi/linux#4907 kernel: configs: Add CONFIG_TINYDRM_HX8357D=m kernel: overlays: Add drm parameter to pitft35-resistive See: https://forums.raspberrypi.com/viewtopic.php?t=330088 kernel: ARM: dts: Add GPIO line names for downstream RPis See: raspberrypi/linux#2760 firmware: board_info: Handle misprogrammed 3B rev 1.2s firmware: mmal: Add mapping for IL OMX_IndexParamBrcmEnableIJGTableScaling param firmware: Handle overlay parameters embedded in overlay_map.dtb See: raspberrypi/linux#4860 firmware: firmware: Add HDMI_PORTS trait firmware: arm_dt: Fix rpi-poe overlay parameters See: raspberrypi/firmware#1689 firmware: jpeghw: Skip APP0 AVI1 headers, regardless of length See: https://forums.raspberrypi.com/viewtopic.php?p=1975448 firmware: camera_subsystem: Report ignored interfaces due to libcamera See: raspberrypi/firmware#1679 firmware: Export os_prefix, overlay_prefix, rsts and boot-mode on all models firmware: vcfw/hdmi_i2c: Initialise all instances from hdmi_i2c_init
Would this be an issue on other hifiberry cards as well? I'm using a DAC+ADC pro and it's not detected on my 5.15.32-rt39 kernel. I'll try hacking together a patch similar to this and see if that helps. Might take a while since I'm using nixos instead of raspberry OS. |
@fps The DAC HD uses a dedicated PLL IC. And the DAC IC on the DAC HD requires that PLL clock to be present to go through the POR and finally allow its the detection on the I2C bus. So, here the correct probing is important which had been skrewed by the old DT file. The other Hifiberry cards do not use that concept and therefore, I doubt, a similar patch solves your issue. You may have a look to this issue #5012. We use for Hifiberry OS 5.15.24 without such problems. But please let me know what you find out. |
@j-schambacher It seems the failure is specific to the way the kernel is built/booted on nixos-aarch64. I built the same kernel on raspberry os (64 bit) and the overlay loads fine. |
My Hifiberry Digi+ Pro board is not recognised by 5.15. Could this be the same problem? I've tried the troubleshooting from Hifiberry's site (https://www.hifiberry.com/docs/software/configuring-linux-3-18-x/) to no avail. |
What changes have you made to config.txt? |
dtoverlay= No user-warnings file. |
Are you using a PI 4? Could it be a HW incompatibility between the Digi and the revision 1.5 of the PI 4? Please have a look here https://www.hifiberry.com/blog/digi2-pro-raspberry-pi-4-1-5-incompatibilities/ |
I've managed to get it working. Multiple installs. Re-sitting the board. Checking everything. Something was amiss. Now it works! Thanks for your help. |
Removed clocks-declarations in I2C sections of the DT-overlay
which kept the devices from probing.
Solves issue #4898 5.15 kernel break Hifiberry DAC 2 HD Hat
Signed-off-by: Joerg Schambacher [email protected]