drivers: staging: bcm2835-isp: Clear LS table handle in the firmware #4952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When all nodes have stopped streaming, ensure the firmware has released its handle on the LS table dmabuf. This is done by passing a null handle in the LS params. Signed-off-by: Naushir Patuck <[email protected]>
|
I tried it and it seemed to do what it said on the tin. |
|
Looks reasonable to me. As discussed, it does have the issue that the (persist and cross-process) control will still list the old (process specific) fd for the lens shading table, but such is life. I'd need to look and see if any other controls take in dmabufs or other fds, and how they then handle the "get" function from other processes. |
|
@pelwell can you merge if you are happy with this change please? |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Mar 28, 2022
…ueing to vbuf2 See: raspberrypi/linux#4961 kernel: overlays/rpi-display: Add support for DRM driver See: raspberrypi/linux#4959 kernel: backport: drm/tiny: Add MIPI DBI compatible SPI driver See: raspberrypi/linux#4954 kernel: drivers: staging: bcm2835-isp: Clear LS table handle in the firmware See: raspberrypi/linux#4952
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Mar 28, 2022
…ueing to vbuf2 See: raspberrypi/linux#4961 kernel: overlays/rpi-display: Add support for DRM driver See: raspberrypi/linux#4959 kernel: backport: drm/tiny: Add MIPI DBI compatible SPI driver See: raspberrypi/linux#4954 kernel: drivers: staging: bcm2835-isp: Clear LS table handle in the firmware See: raspberrypi/linux#4952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all nodes have stopped streaming, ensure the firmware has released its
handle on the LS table dmabuf. This is done by passing a null handle in the
LS params.
Signed-off-by: Naushir Patuck [email protected]