ARM: dts: bcm2835: Switch HSM clock to firmware #5006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the bootloader doesn't initialize boots without a display connected to the HDMI connector, it won't initialize the HSM clock. Then, when Linux boots, the default parent fetched by the clock framework will be the first parent for the HSM clock, which is "gnd". That clock is never registered, leading to the HSM clock being orphaned, which leads to other issues with the recent clock range handling. It's not clear what the proper solution would be, but the firmware clocks driver doesn't have that parenting issue and the clock rate is properly initialized for this clock whenever it hasn't been set by the bootloader. Signed-off-by: Maxime Ripard <[email protected]>
|
The first sentence of the commit message is hard to follow, but the patch looks OK. |
|
I can confirm this fixes the hang on boot on Pi3+ with hdmi unplugged. |
|
Merged with a slightly tweaked commit message. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Apr 25, 2022
See: raspberrypi/linux#5006 kernel: overlays: Add drm parameter to pitft28-resistive See: raspberrypi/linux#5004 kernel: Make IMA able to wait and correctly detect the TPM device See: raspberrypi/linux#5003
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Apr 25, 2022
See: raspberrypi/linux#5006 kernel: overlays: Add drm parameter to pitft28-resistive See: raspberrypi/linux#5004 kernel: Make IMA able to wait and correctly detect the TPM device See: raspberrypi/linux#5003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to fix a stall on the Pi3 when it boots without an HDMI display connected.
It was reported in the PR #4940