clk-raspberrypi: Minimise firmware clocks #5041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dom Cobley <[email protected]>
Signed-off-by: Dom Cobley <[email protected]>
|
@mripard does this seem okay? |
|
It looks good to me :) |
|
@pelwell okay to merge? |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jun 6, 2022
See: raspberrypi/linux#5041 kernel: media: i2c: imx477: Correct minimum exposure lines See: raspberrypi/linux#5050 kernel: arm64: Initialize jump labels before setup_machine_fdt()
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jun 6, 2022
See: raspberrypi/linux#5041 kernel: media: i2c: imx477: Correct minimum exposure lines See: raspberrypi/linux#5050 kernel: arm64: Initialize jump labels before setup_machine_fdt()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-on from #4940
Currently, we don't try to minimise most firmware clocks.
e.g. if hevc requests a 550MHz clock, it continues to run at 550MHz after hevc driver has dropped its request,
and the same happens for all other non-minimised clocks.
This results in a higher required chip voltage, and so more heat/power than is necessary.
When minimising clocks you do need to switch from the
clk_set_rateAPI, toclk_set_min_rateAPI.I believe all fw clocks are using that API, apart from v3d which I've updated.