vc-sm-cma: Restore correct cache maintainance operations #5047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been using the more expensive flush operations rather than invalidate and clean since kernel rpi-5.9.y These are exposed with: 52f1453 Re-expose some dmi APIs for use in VCSM But I believe that commit was dropped when (non-cma) vc-sm was dropped, and didn't get updated when the commit was restored Signed-off-by: Dom Cobley <[email protected]>
|
Ping @6by9 |
|
Doesn't this break 64bit kernels? Those functions only appear to exist for 32bit ARM architectures. |
Ah, this is all under a |
|
This will do no harm, but AFAIK it is only used by the Pi3 HEVC decode, not generic cache management of vcsm buffers. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 27, 2022
kernel: kms/vc4_hdmi: Refuse 4096x2160@60 hdmi modes See: raspberrypi/linux#5038 kernel: vc-sm-cma: Restore correct cache maintainance operations See: raspberrypi/linux#5047
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
May 27, 2022
kernel: kms/vc4_hdmi: Refuse 4096x2160@60 hdmi modes See: raspberrypi/linux#5038 kernel: vc-sm-cma: Restore correct cache maintainance operations See: raspberrypi/linux#5047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using the more expensive flush operations rather than
invalidate and clean since kernel rpi-5.9.y
These are exposed with:
52f1453 Re-expose some dmi APIs for use in VCSM
But I believe that commit was dropped when (non-cma) vc-sm was dropped,
and didn't get updated when the commit was restored
Signed-off-by: Dom Cobley [email protected]