vc4_hdmi: Avoid log spam for audio start failure #5265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We regularly get dmesg error reports of: [ 18.184066] hdmi-audio-codec hdmi-audio-codec.3.auto: ASoC: error at snd_soc_dai_startup on i2s-hifi: -19 [ 18.184098] MAI: soc_pcm_open() failed (-19) Currently I get 30 of these when booting to desktop. We always say, ignore they are harmless, but removing them would be good. A bit of investigation shows, for me, the errors are all generated by second, unused hdmi interface. It shows as an alsa device, and pulseaudio attempts to open it (numerous times), generating a kernel error message each time. systemctl --user restart pulseaudio.service generates 6 additional error messages. The error messages all come through: https://github.com/raspberrypi/linux/blob/a009a9c0d79dfec114ee5102ec3d3325a172c952/sound/soc/soc-pcm.c#L39 which suggests returning ENOTSUPP, rather that ENODEV will be quiet. And indeed it is. Note: earlier kernels do not have the quiet ENOTSUPP, so additional cherry-picks will be needed to backport Signed-off-by: Dom Cobley <[email protected]>
|
See: #4575 |
|
Looks reasonable to me. |
|
I've also cherry-picked: to rpi-5.15.y and rpi-6.0.y trees which is needed to make ENOTSUPP quiet. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Dec 6, 2022
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We regularly get dmesg error reports of:
[ 18.184066] hdmi-audio-codec hdmi-audio-codec.3.auto: ASoC: error at snd_soc_dai_startup on i2s-hifi: -19
[ 18.184098] MAI: soc_pcm_open() failed (-19)
Currently I get 30 of these when booting to desktop. We always say, ignore they are harmless, but removing them would be good.
A bit of investigation shows, for me, the errors are all generated by second, unused hdmi interface.
It shows as an alsa device, and pulseaudio attempts to open it (numerous times), generating a kernel error message each time.
systemctl --user restart pulseaudio.service generates 6 additional error messages.
The error messages all come through:
linux/sound/soc/soc-pcm.c
Line 39 in a009a9c
which suggests returning ENOTSUPP, rather that ENODEV will be quiet. And indeed it is.
Note: earlier kernels do not have the quiet ENOTSUPP, so additional cherry-picks will be needed to backport
Signed-off-by: Dom Cobley [email protected]