Fix HDMI audio passthrough issues #5518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 04b49b9 upstream. The SADs of compressed formats contain the channel and sample rate info of the audio data inside the compressed stream, but when building constraints we must use the rates and channels used to transport the compressed streams. eg 48kHz 6ch EAC3 needs to be transmitted as a 2ch 192kHz stream. This patch fixes the constraints for the common AC3 and DTS formats, the constraints for the less common MPEG, DSD etc formats are copied directly from the info in the SADs as before as I don't have the specs and equipment to test those. Signed-off-by: Matthias Reichl <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
commit 4e08713 upstream. According to CTA 861 the channel/speaker allocation info in the audio infoframe only applies to uncompressed (PCM) audio streams. The channel count info should indicate the number of channels in the transmitted audio, which usually won't match the number of channels used to transmit the compressed bitstream. Some devices (eg some Sony TVs) will refuse to decode compressed audio if these values are not set correctly. To fix this we can simply set the channel count to 0 (which means "refer to stream header") and set the channel/speaker allocation to 0 as well (which would mean stereo FL/FR for PCM, a safe value all sinks will support) when transmitting compressed audio. Signed-off-by: Matthias Reichl <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
|
I've been running with these for a couple of months, and they fixed an issue we saw with a Sony TV. |
|
Thanks! |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jul 3, 2023
kernel: overlays: jedec-spi-nor: Add speed parameter kernel: Fix HDMI audio passthrough issues See: raspberrypi/linux#5518 kernel: raspberrypi/linux#5523 See: raspberrypi/linux#5523
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jul 3, 2023
kernel: overlays: jedec-spi-nor: Add speed parameter kernel: Fix HDMI audio passthrough issues See: raspberrypi/linux#5518 kernel: raspberrypi/linux#5523 See: raspberrypi/linux#5523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ALSA didn't set up proper constraints for compressed audio (eg 192kHz 8ch for DTS-HD and Dolby TrueHD) which prevented applications like kodi to pass through those stream to TVs/AVRs.
@popcornmix also reported that his Sony TV refused to decode TrueHD streams because the channel info in the audio infoframe was incorrect.
We've carried both fixes in LibreELEC for a while and they were just accepted upstream and have been queued up for linux-next