Skip to content

configs: enable pps_core module #5739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lightswitch05
Copy link

It seems the pps_core module has disappeared. I've been able to enable the pps_gpio module, but not pps_core. Perhaps this configuration needs to be added? There is also a chance I'm way off base, thank you in advance for having a look at the PR.

@pelwell
Copy link
Contributor

pelwell commented Nov 23, 2023

What you've done is changed PPS from being built-in to being an external module, which is a step backwards. ntp_core (enabled with CONFIG_NTP_PPS) is not supported because we set CONFIG_NO_HZ_COMMON=y:

config NTP_PPS
	bool "PPS kernel consumer support"
	depends on !NO_HZ_COMMON
	help
	  This option adds support for direct in-kernel time
	  synchronization using an external PPS signal.

	  It doesn't work on tickless systems at the moment.

But that just means you need an external program to perform the synchronisation - isn't that what chronyd does?

FYI none of this has changed since 5.10, except for PPS being built-in.

@pelwell pelwell closed this Nov 23, 2023
@lightswitch05
Copy link
Author

lightswitch05 commented Nov 23, 2023

Thank you for your response @pelwell. Your example is showing NTP_PPS, but this PR is for CONFIG_PPS. Is that not a different configuration?

The issue I'm having isn't setting up time sync with either chrony or NTP, but just getting the system to recognize the PPS device and create /dev/pps0.

I was torn between the m setting and the y. Or maybe this CONFIG_PPS config is being defaulted to y somewhere else?

@pelwell
Copy link
Contributor

pelwell commented Nov 23, 2023

CONFIG_PPS=y is being selected by something else. For each of the defconfigs, run:

$ make ARCH=arm <thing>_defconfig
$ grep PPS .config
$ make ARCH=arm savedefconfig
$ diff <thing>_defconfig defconfig

(or ARCH=arm64)
You'll see that CONFIG_PPS=y is set in all cases, and that when the defconfig is regenerated your setting is dropped.

@lightswitch05
Copy link
Author

Ah ok, thank you for clearing that up for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants