drm/vc4: Fix atomic_async_check to call the right mode_set function #5860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popcornmix
approved these changes
Jan 17, 2024
|
Apologies - missed getting the vc4 pointer. Updating. |
vc4_plane_atomic_async_check was always calling vc4_plane_mode_set to validate and generate the dlist for the check. If async_check decided it had to fall back to a sync commit, then this GEN4/5 dlist could get used on GEN6. Call either vc4_plane_mode_set or vc6_plane_mode_set as appropriate. Fixes: 1ab1fbb ("drm/vc4: hvs: Support BCM2712 HVS") Signed-off-by: Dave Stevenson <[email protected]>
|
Should be fixed now. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 18, 2024
See: raspberrypi/linux#5827 kernel: drm/vc4: Fix atomic_async_check to call the right mode_set function See: raspberrypi/linux#5860
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jan 18, 2024
See: raspberrypi/linux#5827 kernel: drm/vc4: Fix atomic_async_check to call the right mode_set function See: raspberrypi/linux#5860
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vc4_plane_atomic_async_check was always calling vc4_plane_mode_set to validate and generate the dlist for the check. If async_check decided it had to fall back to a sync commit, then this GEN4/5 dlist could get used on GEN6.
Call either vc4_plane_mode_set or vc6_plane_mode_set as appropriate.
Fixes: 1ab1fbb ("drm/vc4: hvs: Support BCM2712 HVS")