RP1 VEC: Use tv_mode from command line, align enum with drm_connector; tidy #5885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@6by9 Shall I go ahead and remove the "tv_norm" parameter altogether? I am in two minds about it. (I think the VEC driver will need at least one parameter, either for enabling 'vintage' modes and/or defining a custom mode, prior to evaluating the "video=" mode; but it need not be the existing "tv_norm" parameter.) |
njhollinghurst
force-pushed
the
tv_mode_from_cmdline
branch
from
1185447 to
e951995
Compare
6by9
reviewed
Jan 24, 2024
njhollinghurst
force-pushed
the
tv_mode_from_cmdline
branch
from
e951995 to
75e903a
Compare
Merged
njhollinghurst
force-pushed
the
tv_mode_from_cmdline
branch
from
75e903a to
12e76e4
Compare
Use the standard enum drm_connector_tv_mode instead of a private enum and switch from the legacy to the standard tv_mode property. Remove the module parameter "tv_norm". Instead, get tv_mode from the command line and make this the connector's default TV mode. Don't restrict the choice of modes based on tv_mode, but interpret nonstandard combinations as NTSC or PAL, depending on resolution. Thus the default tv_mode=NTSC effectively means "Auto". Tweak the advertised horizontal timings for 625/50 to match Rec.601 Signed-off-by: Nick Hollinghurst <[email protected]>
njhollinghurst
force-pushed
the
tv_mode_from_cmdline
branch
from
12e76e4 to
2087667
Compare
|
Cherry-picked this back onto the rebased rpi-6.6.y. Will do a quick re-test and then merge. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 7, 2024
kernel: Improve I2C timing (again) See: raspberrypi/linux#5916 kernel: drm/vc4: Drop planes that have 0 destination size See: raspberrypi/linux#5929 kernel: drm: rp1: VEC and DPI drivers: Fix bug #5901 See: raspberrypi/linux#5925 kernel: drivers: media: cfe: Increase default size of embedded buffer See: raspberrypi/linux#5923 kernel: RP1 VEC: Use tv_mode from command line, align enum with drm_connector; tidy See: raspberrypi/linux#5885 kernel: ARM: dts: Standardise downstream Pi GPIO pin names See: raspberrypi/linux#5902 kernel: ASoC: DACplusADCPro - fix 16bit sample support in clock consumer mode See: raspberrypi/linux#5919 kernel: ASoC: adds support for Hifiberry AMP4Pro to the dacplus driver See: raspberrypi/linux#5918 kernel: ASoC: DACplus - fix 16bit sample support in clock consumer mode See: raspberrypi/linux#5917
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Feb 7, 2024
kernel: Improve I2C timing (again) See: raspberrypi/linux#5916 kernel: drm/vc4: Drop planes that have 0 destination size See: raspberrypi/linux#5929 kernel: drm: rp1: VEC and DPI drivers: Fix bug #5901 See: raspberrypi/linux#5925 kernel: drivers: media: cfe: Increase default size of embedded buffer See: raspberrypi/linux#5923 kernel: RP1 VEC: Use tv_mode from command line, align enum with drm_connector; tidy See: raspberrypi/linux#5885 kernel: ARM: dts: Standardise downstream Pi GPIO pin names See: raspberrypi/linux#5902 kernel: ASoC: DACplusADCPro - fix 16bit sample support in clock consumer mode See: raspberrypi/linux#5919 kernel: ASoC: adds support for Hifiberry AMP4Pro to the dacplus driver See: raspberrypi/linux#5918 kernel: ASoC: DACplus - fix 16bit sample support in clock consumer mode See: raspberrypi/linux#5917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix #5864, targeting Linux 6.6
I narrowly kept the "tv_norm" module parameter in this draft; but it's somewhat redundant now that we can use video/tv_mode.