Add SunFounder Pironman 5 overlay #6087
Conversation
There was a problem hiding this comment.
There are a few minor issues I've discussed in inline comments, but the main problem with this overlay is that it doesn't have either a Makefile entry (so it won't get built) or a README entry (so people won't know what it does or how to use it).
Makefile entries should be in alphabetical/ASCII order, as should the README, and README entries need 2 blank lines between them, strict indentation (match the others) and no TAB characters. If you get it wrong, the dtoverlay checker will complain. For this first attempt it said:
Overlays without documentation:
sunfounder-pironman5
Overlays missing from the Makefile:
sunfounder-pironman5
Failed
| fragment@2 { | ||
| target-path = "/"; | ||
| __overlay__ { | ||
| gpio_ir: ir-receiver@12 { |
There was a problem hiding this comment.
The convention is to use hexadecimal "addresses" after the "@". The "12" here is 0x12, i.e. 18, which matches the gpio-ir overlay you've based this on. Because you've changed the GPIO to (decimal/denary) 12, you should also change the address to "@c". In that way it can coexist with a regular gpio-ir overlay on GPIO 18.
| fragment@3 { | ||
| target = <&gpio>; | ||
| __overlay__ { | ||
| gpio_ir_pins: gpio_ir_pins@12 { |
| /plugin/; | ||
|
|
||
| / { | ||
| compatible = "brcm,bcm2835"; |
There was a problem hiding this comment.
We have a lot of overlays that use spaces for indents, including gpio-ir. I'm not bothered about these warnings.
| ir = <&gpio_ir>,"status"; | ||
| ir_pins = <&gpio_ir>,"gpios:4", <&gpio_ir>,"reg:0", <&gpio_ir_pins>,"brcm,pins:0", <&gpio_ir_pins>,"reg:0"; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Delete this blank line, and put a newline at the end of the last line to keep git happy.
There was a problem hiding this comment.
Yes! Great, Thanks for all the suggestions!
|
Note: this was merged to 6.1 kernel which is no longer used by RPiOS. |
Thanks for the note, So do i need to cherry pick it in 6.6, than make another pull request? and, when it will be on the raspberry pi os? just wait the next raspberry pi os update? or maybe a kernal upgrade will take affect? |
No, it's OK - it's there now (b429eb7).
It shouldn't be too long until the next update to the stable branch. |
|
Great! Thank you pelwell! |
See: raspberrypi/linux#6110 kernel: DTS: overlays: fix Pi 5 midi-over-UART See: raspberrypi/linux#6109 kernel: DTS: rp1: fix setting xHCI TX burst fifo thresholds See: raspberrypi/linux#6107 kernel: Fix UVC gadget support on 32-bit systems See: raspberrypi/linux#6095 kernel: Add SunFounder Pironman 5 overlay See: raspberrypi/linux#6087 kernel: configs: Add various Intel Ethernet drivers See: raspberrypi/linux#5797 See: raspberrypi/linux#6102 kernel: ARM: dts: Move virtgpio under the firmware node
See: raspberrypi/linux#6110 kernel: DTS: overlays: fix Pi 5 midi-over-UART See: raspberrypi/linux#6109 kernel: DTS: rp1: fix setting xHCI TX burst fifo thresholds See: raspberrypi/linux#6107 kernel: Fix UVC gadget support on 32-bit systems See: raspberrypi/linux#6095 kernel: Add SunFounder Pironman 5 overlay See: raspberrypi/linux#6087 kernel: configs: Add various Intel Ethernet drivers See: raspberrypi/linux#5797 See: raspberrypi/linux#6102 kernel: ARM: dts: Move virtgpio under the firmware node
No description provided.