staging: bcm2835_codec: Pass framerate to the component if set late #6108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@popcornmix @naushir Any chance of a review or comment? Naush - it fixes the codec storing the wrong framerate that was raised in raspberrypi/rpicam-apps#664 |
popcornmix
reviewed
May 13, 2024
|
Apart from the setting of |
For video encoding, if the framerate was set after the component was created, then it wasn't set correctly on the port, and an old value was encoded in the bitstream. Update the port status when the framerate is set. raspberrypi/rpicam-apps#664 Signed-off-by: Dave Stevenson <[email protected]>
popcornmix
approved these changes
May 14, 2024
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 20, 2024
kernel: RGB order override for DPI See: raspberrypi/linux#6156 kernel: Minor panel fixups See: raspberrypi/linux#6176 kernel: dtoverlays: Fix noints mode of mcp23017 See: raspberrypi/linux#6174 kernel: DTS: bcm2712: set nonzero QoS values for PCIE1 See: raspberrypi/linux#6171 kernel: staging: bcm2835_codec: Pass framerate to the component if set late See: raspberrypi/linux#6108 kernel: spi: dw: Handle any number of gpiod CS lines See: raspberrypi/linux#6161
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
May 20, 2024
kernel: RGB order override for DPI See: raspberrypi/linux#6156 kernel: Minor panel fixups See: raspberrypi/linux#6176 kernel: dtoverlays: Fix noints mode of mcp23017 See: raspberrypi/linux#6174 kernel: DTS: bcm2712: set nonzero QoS values for PCIE1 See: raspberrypi/linux#6171 kernel: staging: bcm2835_codec: Pass framerate to the component if set late See: raspberrypi/linux#6108 kernel: spi: dw: Handle any number of gpiod CS lines See: raspberrypi/linux#6161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For video encoding, if the framerate was set after the component was created, then it wasn't set correctly on the port, and an old value was encoded in the bitstream.
Update the port status when the framerate is set.
raspberrypi/rpicam-apps#664